Review Request 121168: Ensure a different so-name for Qt4 and Qt5

[Aleix Pol Gonzalez]

> On Nov. 18, 2014, 3:19 p.m., Ivan Romanov wrote:
> > It won't be fixed. Change major version is really bad idea.
> > Close review request and read INSTALL.

I don't understand your review.

Why is it a bad idea? What do you want me to see in INSTALL?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121168/#review70590
-----------------------------------------------------------


On Nov. 18, 2014, 2:53 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121168/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 2:53 p.m.)
> 
> 
> Review request for Kubuntu and Ivan Romanov.
> 
> 
> Repository: qca
> 
> 
> Description
> -------
> 
> Qt4 and Qt5 versions can't have the same so-name. An application compiled against Qt4 won't work if suddenly it finds a Qt5 dependency.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7adacf1 
> 
> Diff: https://git.reviewboard.kde.org/r/121168/diff/
> 
> 
> Testing
> -------
> 
> Stills builds, things didn't seem to break.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20141118/8d803fbc/attachment.html>