Review Request 121748: with qapt 3.1 use a new isInUpdatePhase for upgradable state

Aleix Pol Gonzalez aleixpol at kde.org
Tue Dec 30 01:19:17 UTC 2014



> On Dec. 30, 2014, 12:18 a.m., Aleix Pol Gonzalez wrote:
> > libmuon/backends/ApplicationBackend/Application.cpp, line 496
> > <https://git.reviewboard.kde.org/r/121748/diff/1/?file=337145#file337145line496>
> >
> >     I would remove the ifdef, muon is not meant to work on any system using qapt 3.0 anyway, is it?
> 
> Harald Sitter wrote:
>     Maybe, means I need to release qapt 3.1 before muon though, not sure I can be bothered to TBH. Also releasing qapt is slightly scary because of the amount of distro tooling built ontop of it, so I think rushing that out the door is not necessarily a good idea. :S
> 
> Aleix Pol Gonzalez wrote:
>     meh. whatever. :/
> 
> Harald Sitter wrote:
>     I could put a "// TODO: remove when released" there if that helps?

Well it's kind of obvious.

Just go for it and don't look back. :D


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121748/#review72759
-----------------------------------------------------------


On Dec. 30, 2014, 12:07 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121748/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 12:07 a.m.)
> 
> 
> Review request for Kubuntu, Muon Package Management Suite and Aleix Pol Gonzalez.
> 
> 
> Repository: muon
> 
> 
> Description
> -------
> 
> this allows ubuntu's update phasing to take effect
> 
> 
> Diffs
> -----
> 
>   libmuon/backends/ApplicationBackend/Application.cpp 0fe8c851ac6630f1d8a16aed2bc4181ecc387358 
>   libmuon/backends/ApplicationBackend/ApplicationUpdates.cpp 7963ac2908379e8b9b2ed0092fb80e181c868586 
> 
> Diff: https://git.reviewboard.kde.org/r/121748/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20141230/9beacda3/attachment.html>


More information about the kubuntu-devel mailing list