Review Request 121748: with qapt 3.1 use a new isInUpdatePhase for upgradable state

Aleix Pol Gonzalez aleixpol at kde.org
Tue Dec 30 00:18:15 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121748/#review72759
-----------------------------------------------------------

Ship it!


Only some nitpicking.


libmuon/backends/ApplicationBackend/Application.cpp
<https://git.reviewboard.kde.org/r/121748/#comment50681>

    I would remove the ifdef, muon is not meant to work on any system using qapt 3.0 anyway, is it?


- Aleix Pol Gonzalez


On Dec. 30, 2014, 12:07 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121748/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 12:07 a.m.)
> 
> 
> Review request for Kubuntu, Muon Package Management Suite and Aleix Pol Gonzalez.
> 
> 
> Repository: muon
> 
> 
> Description
> -------
> 
> this allows ubuntu's update phasing to take effect
> 
> 
> Diffs
> -----
> 
>   libmuon/backends/ApplicationBackend/Application.cpp 0fe8c851ac6630f1d8a16aed2bc4181ecc387358 
>   libmuon/backends/ApplicationBackend/ApplicationUpdates.cpp 7963ac2908379e8b9b2ed0092fb80e181c868586 
> 
> Diff: https://git.reviewboard.kde.org/r/121748/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20141230/9dc1746d/attachment.html>


More information about the kubuntu-devel mailing list