Review Request 121729: implement DependencyInfo::multiArchAnnotation and filter invalid deps

[Aleix Pol Gonzalez]

> On Dec. 29, 2014, 12:31 a.m., Aleix Pol Gonzalez wrote:
> > I like it, how hard would it be to add a unit test for this?
> 
> Harald Sitter wrote:
>     Should be easy. Though I do wonder if we should just throw some time at figuring out a proper test setup and then take it from there. apt itself allows for 100% mock data to be supplied (package lists, caches, configs, what have you), but we seem to lack some of the facilities to construct a backend with an entire set of mock data.
> 
> Harald Sitter wrote:
>     Oh, fwiw, the parser is entirely test covered in apt-pkg, so our testing opportunity with the parse function is pretty much limited to
>     - does the OR operator work
>     - does the annotation splitting work
>     other than those to things it really is just a very fancy data class ^^

Well, you're adding a parser for the multiArch field. It just happens to be colon-separated.

If you could add a simple test there, you would make me very happy. Even more, inmensely happy.
I don't know what testing strategies you have in mind, but currently we're already falling behind...


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121729/#review72647
-----------------------------------------------------------


On Dec. 28, 2014, 11:27 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121729/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 11:27 p.m.)
> 
> 
> Review request for Kubuntu, LibQApt, Aleix Pol Gonzalez, and Michael Stemle.
> 
> 
> Repository: libqapt
> 
> 
> Description
> -------
> 
> this is a QString property that may be empty or contain the multiarch
> annotation of a dependency
> 
> looks like this:
> "Depends: foo:any"
> 
> this will enable deb-installer to properly handle Multi-Arch: allow mode
> 
> 
> Diffs
> -----
> 
>   src/dependencyinfo.h 3ce031ac37b3684b048ddc0f353b5f20b1b92e6f 
>   src/dependencyinfo.cpp 9e58054a92cf96f6ba80f89626b0bc5dd075411a 
> 
> Diff: https://git.reviewboard.kde.org/r/121729/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20141229/6d07eae5/attachment-0001.html>