Review Request 121714: Add Package::isInUpdatePhase to allow ubuntu-style update phasing

Aleix Pol Gonzalez aleixpol at kde.org
Mon Dec 29 01:01:37 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121714/#review72651
-----------------------------------------------------------

Ship it!



src/package.cpp
<https://git.reviewboard.kde.org/r/121714/#comment50623>

    return d->isInUpdatePhase;



src/package.cpp
<https://git.reviewboard.kde.org/r/121714/#comment50625>

    QStringLiteral("%1...



src/package.cpp
<https://git.reviewboard.kde.org/r/121714/#comment50624>

    return d->setInUpdatePhase(rand <= phasedUpdatePercent);


It's pretty cool that ubuntu has that feature! :)
/me likes

- Aleix Pol Gonzalez


On Dec. 28, 2014, 3:08 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121714/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 3:08 p.m.)
> 
> 
> Review request for Kubuntu, LibQApt, Aleix Pol Gonzalez, and Michael Stemle.
> 
> 
> Repository: libqapt
> 
> 
> Description
> -------
> 
> Add Package::isInUpdatePhase to allow ubuntu-style update phasing
> 
> Update phasing is an additional feature provided by ubuntu/launchpad that
> sets an additional control field called Phased-Update-Percentage. This
> field defines a percentage of systems to which an update should be
> delivered. This is to minimize exposure from update regressions by
> gradually increasing the amount of systems to get this update.
> 
> To ensure even distribution of machines in any given percentage set of
> phasing a dicrete randomizer with stable seed is used. A stable seed
> based on packagesource-version-uniquemachineid is thrown at a simple
> randomizer to get a percentage at which a given machine would fall into
> the phasing, once the phasing defined by the remote repository exceeds the
> machine specific phasing the query function returns true and a qapt client
> *may* choose to honor this or not.
> 
> Whether or not phasing is going to be respected is a purely client specific
> decision/setting. I.e. this also requires changes to muon-updater to
> get phasing landed.
> 
> 
> Diffs
> -----
> 
>   src/package.h 0a3e58f8cceedda93c9d99c04d7ff0aba04e3ff9 
>   src/package.cpp 673390ed88d6faa001e025b1381cc0a4d993aa87 
> 
> Diff: https://git.reviewboard.kde.org/r/121714/diff/
> 
> 
> Testing
> -------
> 
> make & make test & install & test new function in a muon-updater context
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20141229/d7f8fb82/attachment.html>


More information about the kubuntu-devel mailing list