kubuntu-automation and lintian warnings

[Philip Muskovac]

Hi,

during the recent 4.10 packaging time me and Rohan noticed that quite a 
few of our KDE packages show lintian warnings, partly caused by the new 
warnings from lintian in raring.
Now that we use kubuntu-initial-upload to generate the packages, only 
the person that runs that sees those warnings and has to extract them 
from the script output. If not they're simply ignored unless a package 
needs fixing and someone sees the warning again when uploading an 
updated package to the PPA.

IMO it would be best if the kubuntu-ppa-build-status could show the 
relevant warnings so however has time can fix them. That way they 
wouldn't be forgotten either. When looking at that we noticed that 
lintian isn't being run at build-time so there is no lintian output in 
the logs that one could parse in the script.
Below is one way to add that in pkg-kde-tools, I'm open for better ideas.

But generally: Does this makes sense? Or am I worrying about something 
that nobody cares about?

Regards,
Philip

diff -Nru pkg-kde-tools-0.15.3ubuntu1/debian/control 
pkg-kde-tools-0.15.3ubuntu2~ubuntu13.04~ppa4/debian/control
--- pkg-kde-tools-0.15.3ubuntu1/debian/control	2012-11-15 
17:08:19.000000000 +0100
+++ pkg-kde-tools-0.15.3ubuntu2~ubuntu13.04~ppa4/debian/control 
2013-02-02 15:00:07.000000000 +0100
@@ -12,7 +12,7 @@
  Package: pkg-kde-tools
  Architecture: all
  Multi-Arch: foreign
-Depends: ${perl:Depends}, ${misc:Depends}, libdpkg-perl (>= 1.15.6~)
+Depends: ${perl:Depends}, ${misc:Depends}, libdpkg-perl (>= 1.15.6~), 
lintian
  Recommends: dpkg-dev (>= 1.15.6~), libwww-perl
  Suggests: debhelper (>= 7.3.16), cdbs
  Breaks: kdelibs5-dev (<< 4:4.2.2), dpkg-dev (<< 1.15.6~)
diff -Nru pkg-kde-tools-0.15.3ubuntu1/qt-kde-team/2/debian-qt-kde.mk 
pkg-kde-tools-0.15.3ubuntu2~ubuntu13.04~ppa4/qt-kde-team/2/debian-qt-kde.mk
--- pkg-kde-tools-0.15.3ubuntu1/qt-kde-team/2/debian-qt-kde.mk 
2012-08-11 17:43:46.000000000 +0200
+++ 
pkg-kde-tools-0.15.3ubuntu2~ubuntu13.04~ppa4/qt-kde-team/2/debian-qt-kde.mk 
2013-02-02 14:28:38.000000000 +0100
@@ -24,6 +24,9 @@
  # Support list-missing target
  include $(dqk_dir)list-missing.mk

+# lintian support
+include $(dqk_dir)lintian.mk
+
  # KDE packages are parallel safe. Add --parallel to dh_auto_% commands
  $(call set_command_options,dh_auto_%, += --parallel)

@@ -94,7 +97,7 @@
  	fi
  $(foreach t,install-indep install,post_$(t)_dh_install): 
install_to_doc-html_package

-post_binary: list-missing
+post_binary: list-missing lintian

  .PHONY: run_dh_sameversiondep cleanup_manpages install_to_doc-html_package

diff -Nru pkg-kde-tools-0.15.3ubuntu1/qt-kde-team/2/lintian.mk 
pkg-kde-tools-0.15.3ubuntu2~ubuntu13.04~ppa4/qt-kde-team/2/lintian.mk
--- pkg-kde-tools-0.15.3ubuntu1/qt-kde-team/2/lintian.mk	1970-01-01 
01:00:00.000000000 +0100
+++ 
pkg-kde-tools-0.15.3ubuntu2~ubuntu13.04~ppa4/qt-kde-team/2/lintian.mk 
2013-02-02 14:51:13.000000000 +0100
@@ -0,0 +1,26 @@
+# Copyright © 2013 Philip Muskovac <yofel at kubuntu.org>
+# Description: Defines various random rules, including a list-missing rule
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2, or (at
+# your option) any later version.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+ifdef dqk_dir
+
+lintian:
+	@echo "=== Start lintian"
+	@-lintian
+	@echo "=== End lintian"
+
+.PHONY: lintian
+
+endif