[kubuntu-devel] Submitted for your approval: changes to kde-systemsettings

[Sebastian Kügler]

On Thursday 04 January 2007 21:08, Jonathan Riddell wrote:
> On Sat, Dec 16, 2006 at 04:41:20PM -0600, Michael D. Stemle, Jr. wrote:
> > Greetings.  So as one or more of you may know, I've been hacking on
> > kde-systemsettings for a few days, and I've successfully implemented
> > tabs.
> >
> > This functionality seems pretty complete to me.  I was unable to figure
> > out how to keep the icons in the tabs, but I really didn't think anybody
> > would be too heart-broken to see the icons go.
> >
> > Instead of getting the button names from the ui.rc file like it was
> > before, I'm actually deriving the tab name from the menu path right out
> > of menu/systemsettings.desktop.  I'm not quite happy with that way, but
> > it did seem like the only way to really do it.
>
> Looks good to me.  I've committed the patch to SVN and uploaded to
> Feisty.  Many thanks.

Simon is on vacation until somewhen in Feb, I guess he should have a look at 
some point, but I agree that one should be able to merge stuff without him.

That said, I've no opinion on the feature itself, just happen to know about 
Sime's private life :-)
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
One is not superior merely because one sees the world as odious. - 
Chateaubriand (1768-1848)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20070105/e5ee659e/attachment.pgp