[Bug 1762167]

[Valerii Malov]

Git commit b819ef6a35495e12a204cbb241cdb2502c4cd11e by Valerii Malov.
Committed on 29/09/2019 at 20:31.
Pushed by valeriymalov into branch '5.1'.

Cleanup ViewModel a bit and try to fix crash on exit

Summary:
removeTorrent makes changes to torrent list we are currently iterating
on per-item basis, this causees heap-use-after-free in onExit
Just call removeRows which should be functionally the same, but should
delete all items in one batch

Compact ViewModel::Item::update
Fix a few warnings (0 as nullptr, c-style casts)
Remove useless ViewModel::torrentFromIndex variant
Remove unused headers
add CMakeLists.txt.user to gitignore

Test Plan: build with asan, run & exit, see asan stacktrace before
changing onExit

Reviewers: stikonas

Differential Revision: https://phabricator.kde.org/D24149

M  +1    -0    .gitignore
M  +1    -0    ktorrent/CMakeLists.txt
M  +51   -146  ktorrent/view/viewmodel.cpp
M  +10   -11   ktorrent/view/viewmodel.h

https://commits.kde.org/ktorrent/b819ef6a35495e12a204cbb241cdb2502c4cd11e

-- 
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to ktorrent in Ubuntu.
https://bugs.launchpad.net/bugs/1762167

Title:
  ktorrent always crashes on exit

To manage notifications about this bug go to:
https://bugs.launchpad.net/ktorrent/+bug/1762167/+subscriptions