[Bug 1767454]

Harald Sitter sitter.harald at gmail.com
Fri Dec 7 12:55:18 UTC 2018


Git commit 55eb68ff63646050311f8b689752ad500246c916 by Harald Sitter.
Committed on 07/12/2018 at 12:55.
Pushed by sitter into branch 'master'.

fallback to dnssd service discovery if smb listDir failed on root

Summary:
This elevates a problem with newer SMB protocol versions and smbclient
not supporting discovery/browsing. when not using older (as in:
ancient) protocol versions discovery doesn't work and smb:/ gives no
results.

By falling back to DNSSD based discovery we can ensure discovery of DNSSD
remotes (namely linux and osx) is always working. Windows unfortunately
does not support DNSSD and as such will not benefit from this mode of
discovery and continue to be unlisted when using a protocol version
without browsing support.

CHANGELOG: When SMB Discovery is not working (protocol > SMB1) host discovery will now fall back to DNS-SD/Avahi/Bonjour.
Related: bug 390551

Test Plan:
smb.conf:

```
[global]
client min protocol = SMB2
```

Lists devices

Reviewers: #frameworks, #dolphin, broulik

Reviewed By: broulik

Subscribers: acrouthamel, alexde, bcooksley, ngraham, kde-frameworks-
devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D16299

M  +6    -0    CMakeLists.txt
M  +3    -0    config-runtime.h.cmake
M  +16   -3    smb/CMakeLists.txt
M  +1    -0    smb/kio_smb.h
M  +126  -3    smb/kio_smb_browse.cpp

https://commits.kde.org/kio-
extras/55eb68ff63646050311f8b689752ad500246c916

-- 
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1767454

Title:
  "Other Locations" does not automatically find Samba servers in Ubuntu
  18.04

To manage notifications about this bug go to:
https://bugs.launchpad.net/dolphin/+bug/1767454/+subscriptions




More information about the kubuntu-bugs mailing list