[Bug 1240673] Re: Reports 0% charged for fully charged batteries
Martin Pitt
martin.pitt at ubuntu.com
Wed Oct 23 06:47:44 UTC 2013
Saucy SRU uploaded.
** Description changed:
+ SRU INFORMATION:
+ Explanation: This bug was introduced with http://cgit.freedesktop.org/upower/commit/?id=07b95b8e which preferred the kernel's reported percentage ("capacity" sysfs attribute") over calculating it from energy/charge. This exposed some buggy batteries/drivers which sometimes report > 100% charge. As the GObject "percentage" property is defined to be between 0 and 100, trying to set a value > 100% resulted in a warning and defaulting to 0%.
+
+ Fix: http://cgit.freedesktop.org/upower/commit/?id=22da1a0bc ; this
+ clamping already happens at several other points in the code.
+
+ Regression potential: Very low. The code change only applies to the
+ explicit cases of < 0% and > 100%, and these values could have never
+ actually appeared in practice as setting the property to these values
+ fails. It has a test case, and the other test cases prove that this
+ change did not break other configurations. In the worst case (compiler
+ bugs etc.) this update could cause currently working battery information
+ to be wrong, but upower is mostly an informational service these days
+ and thus won't have the ability to completely break the system.
+
+ ORIGINAL BUG:
+
See the following upower dump:
$ upower --dump
Device: /org/freedesktop/UPower/devices/line_power_AC
- native-path: AC
- power supply: yes
- updated: Wed 16 Oct 2013 12:58:28 PM EDT (7198 seconds ago)
- has history: no
- has statistics: no
- line-power
- online: yes
+ native-path: AC
+ power supply: yes
+ updated: Wed 16 Oct 2013 12:58:28 PM EDT (7198 seconds ago)
+ has history: no
+ has statistics: no
+ line-power
+ online: yes
Device: /org/freedesktop/UPower/devices/battery_BAT0
- native-path: BAT0
- vendor: SMP
- model: DELL Y61CV22
- serial: 3840
- power supply: yes
- updated: Wed 16 Oct 2013 12:58:33 PM EDT (7193 seconds ago)
- has history: yes
- has statistics: yes
- battery
- present: yes
- rechargeable: yes
- state: fully-charged
- energy: 66.6 Wh
- energy-empty: 0 Wh
- energy-full: 66.6 Wh
- energy-full-design: 66.6 Wh
- energy-rate: 0.0111 W
- voltage: 12.836 V
- percentage: 0%
- capacity: 76.9167%
- technology: lithium-ion
+ native-path: BAT0
+ vendor: SMP
+ model: DELL Y61CV22
+ serial: 3840
+ power supply: yes
+ updated: Wed 16 Oct 2013 12:58:33 PM EDT (7193 seconds ago)
+ has history: yes
+ has statistics: yes
+ battery
+ present: yes
+ rechargeable: yes
+ state: fully-charged
+ energy: 66.6 Wh
+ energy-empty: 0 Wh
+ energy-full: 66.6 Wh
+ energy-full-design: 66.6 Wh
+ energy-rate: 0.0111 W
+ voltage: 12.836 V
+ percentage: 0%
+ capacity: 76.9167%
+ technology: lithium-ion
Device: /org/freedesktop/UPower/devices/battery_BAT2
- native-path: BAT2
- vendor: Samsung SDI
- model: DELL W1GGM26
- serial: 12515
- power supply: yes
- updated: Wed 16 Oct 2013 12:58:33 PM EDT (7193 seconds ago)
- has history: yes
- has statistics: yes
- battery
- present: yes
- rechargeable: yes
- state: fully-charged
- energy: 31.08 Wh
- energy-empty: 0 Wh
- energy-full: 31.08 Wh
- energy-full-design: 31.08 Wh
- energy-rate: 0.0111 W
- voltage: 12.428 V
- percentage: 0%
- capacity: 81.2857%
- technology: lithium-ion
+ native-path: BAT2
+ vendor: Samsung SDI
+ model: DELL W1GGM26
+ serial: 12515
+ power supply: yes
+ updated: Wed 16 Oct 2013 12:58:33 PM EDT (7193 seconds ago)
+ has history: yes
+ has statistics: yes
+ battery
+ present: yes
+ rechargeable: yes
+ state: fully-charged
+ energy: 31.08 Wh
+ energy-empty: 0 Wh
+ energy-full: 31.08 Wh
+ energy-full-design: 31.08 Wh
+ energy-rate: 0.0111 W
+ voltage: 12.428 V
+ percentage: 0%
+ capacity: 81.2857%
+ technology: lithium-ion
Note that state is fully-charged, but percentage is o% on both batteries. This worked fine on 13.04.
Daemon:
- daemon-version: 0.9.22
- can-suspend: yes
- can-hibernate: no
- on-battery: no
- on-low-battery: no
- lid-is-closed: no
- lid-is-present: yes
- is-docked: no
+ daemon-version: 0.9.22
+ can-suspend: yes
+ can-hibernate: no
+ on-battery: no
+ on-low-battery: no
+ lid-is-closed: no
+ lid-is-present: yes
+ is-docked: no
ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: upower 0.9.22-1ubuntu1
ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3
Uname: Linux 3.11.0-12-generic i686
ApportVersion: 2.12.5-0ubuntu2
Architecture: i386
Date: Wed Oct 16 15:02:33 2013
EcryptfsInUse: Yes
InstallationDate: Installed on 2011-04-04 (925 days ago)
InstallationMedia: Kubuntu 11.04 "Natty Narwhal" - Beta i386 (20110330)
MarkForUpload: True
SourcePackage: upower
UpgradeStatus: Upgraded to saucy on 2013-10-16 (0 days ago)
** Changed in: upower (Ubuntu Saucy)
Status: New => In Progress
--
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1240673
Title:
Reports 0% charged for fully charged batteries
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/upower/+bug/1240673/+subscriptions
More information about the kubuntu-bugs
mailing list