[Bug 1178286]

[Kevin-kofler]

> I think that url can be null is _url cannot be converted, so it looks
legitimate.

1. There's no conversion there. It's just a copy from a const QString & to a writable QString.
2. The thing there is that it checks for if (!url.isNull()) when I think it wants to actually check for if (url.isNull()) without the '!' (or maybe actually for if (url.isEmpty()), again without negation; checking strings for isNull is not recommended and rarely needed). The code looks to me like the intention was to fill in a default value if no URL was given, whereas as written now, it leaves it empty if it was empty and it overwrites it with the default value if it was not empty.

-- 
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to kde4libs in Ubuntu.
https://bugs.launchpad.net/bugs/1178286

Title:
  Security advisory from KDE upstream

To manage notifications about this bug go to:
https://bugs.launchpad.net/kdelibs/+bug/1178286/+subscriptions