[Bug 1156155] Re: Script for menu option "Detailed Memory Information" fails to parse

[Bug Watch Updater]

Launchpad has imported 11 comments from the remote bug at
https://bugs.kde.org/show_bug.cgi?id=314818.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2013-02-10T11:11:13+00:00 Kevin Funk wrote:

Showing the detailled process info of any process yields the above
error.

This worked fine in 4.9.x, afaik.

Reproducible: Always

Reply at: https://bugs.launchpad.net/ubuntu/+source/kde-
workspace/+bug/1156155/comments/0

------------------------------------------------------------------------
On 2013-02-10T11:19:55+00:00 Kevin Funk wrote:

Well, the above comment about ksysguard working fine in 4.9.x is of
course wrong.

The smaps output changed a bit, so the reason is of course the more recent kernel.
See http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=log;h=834f82e2aa9a8ede94b17b656329f850c1471514.

Maybe it is better to just ignore unknown fields instead of throwing
errors?

Reply at: https://bugs.launchpad.net/ubuntu/+source/kde-
workspace/+bug/1156155/comments/1

------------------------------------------------------------------------
On 2013-03-09T21:31:17+00:00 Ralf Jung wrote:

Created attachment 77894
Patch to fix the issue

Attached is a patch to fix the issue.

Reply at: https://bugs.launchpad.net/ubuntu/+source/kde-
workspace/+bug/1156155/comments/2

------------------------------------------------------------------------
On 2013-03-09T22:49:35+00:00 sumski wrote:

Confirming that the patch resolves the problem :-)

Reply at: https://bugs.launchpad.net/ubuntu/+source/kde-
workspace/+bug/1156155/comments/3

------------------------------------------------------------------------
On 2013-03-09T23:46:25+00:00 JohnFlux wrote:

For future-proofing, it seems better to not throw an error at all for
unknown matches.

Reply at: https://bugs.launchpad.net/ubuntu/+source/kde-
workspace/+bug/1156155/comments/4

------------------------------------------------------------------------
On 2013-03-10T09:56:18+00:00 Ralf Jung wrote:

I opened review request https://git.reviewboard.kde.org/r/109385/ for
this to find someone giving me the okay to push this ;-)

(In reply to comment #4)
> For future-proofing, it seems better to not throw an error at all for
> unknown matches.
The intend of the original code was obviously to deal explicitly with all lines in that file. I did not want to change that intend, but if the maintainer tells me this is okay with him, I sure can do that.

Reply at: https://bugs.launchpad.net/ubuntu/+source/kde-
workspace/+bug/1156155/comments/5

------------------------------------------------------------------------
On 2013-03-10T10:04:16+00:00 JohnFlux wrote:

Yep, it's okay by me, thanks :-)

Reply at: https://bugs.launchpad.net/ubuntu/+source/kde-
workspace/+bug/1156155/comments/6

------------------------------------------------------------------------
On 2013-03-10T10:09:43+00:00 Ralf Jung wrote:

Oh, you *are* the maintainer... sorry, I did not know that ;-)
Then I'll change it to ignore unknown lines,a dn push to stable and master.

Reply at: https://bugs.launchpad.net/ubuntu/+source/kde-
workspace/+bug/1156155/comments/7

------------------------------------------------------------------------
On 2013-03-10T10:15:46+00:00 Ralf Jung wrote:

Git commit ecd6271126e7579390183f188d263722381be86a by Ralf Jung.
Committed on 10/03/2013 at 11:12.
Pushed by ralfjung into branch 'master'.

Fix parse error in advanced memroy information for 3.8 kernels

REVIEW: 109385
FIXED-IN: 4.10.2

M  +1    -2    libs/ksysguard/scripts/smaps/main.js

http://commits.kde.org/kde-
workspace/ecd6271126e7579390183f188d263722381be86a

Reply at: https://bugs.launchpad.net/ubuntu/+source/kde-
workspace/+bug/1156155/comments/8

------------------------------------------------------------------------
On 2013-03-10T10:16:20+00:00 JohnFlux wrote:

That would be great, thank you :-)

Reply at: https://bugs.launchpad.net/ubuntu/+source/kde-
workspace/+bug/1156155/comments/9

------------------------------------------------------------------------
On 2013-03-10T10:18:18+00:00 Ralf Jung wrote:

Git commit f41d5f969b94d3bafea56f9fcfc7db5e5d1e3f5f by Ralf Jung.
Committed on 10/03/2013 at 11:12.
Pushed by ralfjung into branch 'KDE/4.10'.

Fix parse error in advanced memroy information for 3.8 kernels

REVIEW: 109385
FIXED-IN: 4.10.2

M  +1    -2    libs/ksysguard/scripts/smaps/main.js

http://commits.kde.org/kde-
workspace/f41d5f969b94d3bafea56f9fcfc7db5e5d1e3f5f

Reply at: https://bugs.launchpad.net/ubuntu/+source/kde-
workspace/+bug/1156155/comments/10


** Changed in: kdebase-workspace
       Status: Unknown => Fix Released

** Changed in: kdebase-workspace
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to kde-workspace in Ubuntu.
https://bugs.launchpad.net/bugs/1156155

Title:
  Script for menu option "Detailed Memory Information" fails to parse

To manage notifications about this bug go to:
https://bugs.launchpad.net/kdebase-workspace/+bug/1156155/+subscriptions