[Bug 999522] Re: [SRU] Fix problems in Qt dragging when all of the window target has been shaped out for input

[Albert Astals Cid]

** Description changed:

  In Unity-2d we use input shaping to define which part of our window
  accepts user input, unfortunately Qt did not have support for that
  feature when dragging from a Qt applications resulting in impossibility
  of dragging in applications like Mumble or KMail.
  
  We fixed this issue with a patch to Qt (that was accepted upstream) but
  sadly that patch had a bug.
  
  This means we need a new patch otherwise when on multimonitor scenarios
  the dropping into the secondary launcher from the drash does still does
  not work.
  
  The new upstream patch (already accepted) can be found at
  https://codereview.qt-project.org/#change,24361 (it needs to
  replace/update kubuntu_33_shaped_drag.diff that only had a partial
  version of the patch)
  
  Fixes https://bugs.launchpad.net/unity-2d/+bug/966236
+ 
+ Copied from the unity-2d bug:
+   Setup:
+     Multi-monitors, launcher per screen
+ 
+   Steps to Repro:
+     1. On non-primary screen, open dash
+     2. Grab an application icon and try to drag & drop it onto the launcher of 
+        non-primary screen
+ 
+     Expected Result:
+        Application tile created in Launcher for that application
+ 
+     Actual Result:
+       .desktop file is placed on desktop under launcher

** Description changed:

  In Unity-2d we use input shaping to define which part of our window
  accepts user input, unfortunately Qt did not have support for that
  feature when dragging from a Qt applications resulting in impossibility
  of dragging in applications like Mumble or KMail.
  
  We fixed this issue with a patch to Qt (that was accepted upstream) but
  sadly that patch had a bug.
  
  This means we need a new patch otherwise when on multimonitor scenarios
  the dropping into the secondary launcher from the drash does still does
  not work.
  
  The new upstream patch (already accepted) can be found at
  https://codereview.qt-project.org/#change,24361 (it needs to
  replace/update kubuntu_33_shaped_drag.diff that only had a partial
  version of the patch)
  
  Fixes https://bugs.launchpad.net/unity-2d/+bug/966236
  
+ [Test Case]
  Copied from the unity-2d bug:
-   Setup:
-     Multi-monitors, launcher per screen
+   Setup:
+     Multi-monitors, launcher per screen
  
-   Steps to Repro:
-     1. On non-primary screen, open dash
-     2. Grab an application icon and try to drag & drop it onto the launcher of 
-        non-primary screen
+   Steps to Repro:
+     1. On non-primary screen, open dash
+     2. Grab an application icon and try to drag & drop it onto the launcher of
+        non-primary screen
  
-     Expected Result:
-        Application tile created in Launcher for that application
+     Expected Result:
+        Application tile created in Launcher for that application
  
-     Actual Result:
-       .desktop file is placed on desktop under launcher
+     Actual Result:
+       .desktop file is placed on desktop under launcher

** Description changed:

  In Unity-2d we use input shaping to define which part of our window
  accepts user input, unfortunately Qt did not have support for that
  feature when dragging from a Qt applications resulting in impossibility
  of dragging in applications like Mumble or KMail.
  
  We fixed this issue with a patch to Qt (that was accepted upstream) but
  sadly that patch had a bug.
  
  This means we need a new patch otherwise when on multimonitor scenarios
  the dropping into the secondary launcher from the drash does still does
  not work.
  
  The new upstream patch (already accepted) can be found at
  https://codereview.qt-project.org/#change,24361 (it needs to
  replace/update kubuntu_33_shaped_drag.diff that only had a partial
  version of the patch)
  
  Fixes https://bugs.launchpad.net/unity-2d/+bug/966236
  
  [Test Case]
  Copied from the unity-2d bug:
    Setup:
      Multi-monitors, launcher per screen
  
    Steps to Repro:
      1. On non-primary screen, open dash
      2. Grab an application icon and try to drag & drop it onto the launcher of
         non-primary screen
  
      Expected Result:
         Application tile created in Launcher for that application
  
      Actual Result:
        .desktop file is placed on desktop under launcher
+ 
+ [Test Case #2]
+ If you are hardcore you can actually run the unit-tests I added in https://codereview.qt-project.org/#change,24361 itself

** Description changed:

  In Unity-2d we use input shaping to define which part of our window
  accepts user input, unfortunately Qt did not have support for that
  feature when dragging from a Qt applications resulting in impossibility
  of dragging in applications like Mumble or KMail.
  
  We fixed this issue with a patch to Qt (that was accepted upstream) but
  sadly that patch had a bug.
  
  This means we need a new patch otherwise when on multimonitor scenarios
  the dropping into the secondary launcher from the drash does still does
  not work.
  
- The new upstream patch (already accepted) can be found at
- https://codereview.qt-project.org/#change,24361 (it needs to
- replace/update kubuntu_33_shaped_drag.diff that only had a partial
- version of the patch)
+ The new upstream patch (already accepted) can be found at https://codereview.qt-project.org/#change,24361 (it needs to replace/update kubuntu_33_shaped_drag.diff that only had a partial version of the patch)
+ If it helps http://qt.gitorious.org/qt/qt/commit/c3eb2e63425c47b8e3eeb7416e225fab10c5c15a is the same patch in a different repo
  
  Fixes https://bugs.launchpad.net/unity-2d/+bug/966236
+ 
+ [Impact]
+ Severity: Can't drag and drop to launchers in non primary screen
+ Frequency: Every time you try to do it :D
+ 
+ [Development Fix]
+ Fix the drag and drop code
  
  [Test Case]
  Copied from the unity-2d bug:
    Setup:
      Multi-monitors, launcher per screen
  
    Steps to Repro:
      1. On non-primary screen, open dash
      2. Grab an application icon and try to drag & drop it onto the launcher of
         non-primary screen
  
      Expected Result:
         Application tile created in Launcher for that application
  
      Actual Result:
        .desktop file is placed on desktop under launcher
  
  [Test Case #2]
  If you are hardcore you can actually run the unit-tests I added in https://codereview.qt-project.org/#change,24361 itself
+ 
+ [Regression Potential]
+ It is touching the Drag and Drop code, potentially any drag and drop from a Qt program might break

** Description changed:

  In Unity-2d we use input shaping to define which part of our window
  accepts user input, unfortunately Qt did not have support for that
  feature when dragging from a Qt applications resulting in impossibility
  of dragging in applications like Mumble or KMail.
  
  We fixed this issue with a patch to Qt (that was accepted upstream) but
  sadly that patch had a bug.
  
  This means we need a new patch otherwise when on multimonitor scenarios
  the dropping into the secondary launcher from the drash does still does
  not work.
  
  The new upstream patch (already accepted) can be found at https://codereview.qt-project.org/#change,24361 (it needs to replace/update kubuntu_33_shaped_drag.diff that only had a partial version of the patch)
  If it helps http://qt.gitorious.org/qt/qt/commit/c3eb2e63425c47b8e3eeb7416e225fab10c5c15a is the same patch in a different repo
  
  Fixes https://bugs.launchpad.net/unity-2d/+bug/966236
  
  [Impact]
- Severity: Can't drag and drop to launchers in non primary screen
+ Severity: Can't drag and drop to Unity-2d launchers in non primary screen
  Frequency: Every time you try to do it :D
  
  [Development Fix]
  Fix the drag and drop code
  
  [Test Case]
  Copied from the unity-2d bug:
    Setup:
      Multi-monitors, launcher per screen
  
    Steps to Repro:
      1. On non-primary screen, open dash
      2. Grab an application icon and try to drag & drop it onto the launcher of
         non-primary screen
  
      Expected Result:
         Application tile created in Launcher for that application
  
      Actual Result:
        .desktop file is placed on desktop under launcher
  
  [Test Case #2]
  If you are hardcore you can actually run the unit-tests I added in https://codereview.qt-project.org/#change,24361 itself
  
  [Regression Potential]
  It is touching the Drag and Drop code, potentially any drag and drop from a Qt program might break

** Description changed:

  In Unity-2d we use input shaping to define which part of our window
  accepts user input, unfortunately Qt did not have support for that
  feature when dragging from a Qt applications resulting in impossibility
  of dragging in applications like Mumble or KMail.
  
  We fixed this issue with a patch to Qt (that was accepted upstream) but
  sadly that patch had a bug.
  
  This means we need a new patch otherwise when on multimonitor scenarios
  the dropping into the secondary launcher from the drash does still does
  not work.
  
  The new upstream patch (already accepted) can be found at https://codereview.qt-project.org/#change,24361 (it needs to replace/update kubuntu_33_shaped_drag.diff that only had a partial version of the patch)
  If it helps http://qt.gitorious.org/qt/qt/commit/c3eb2e63425c47b8e3eeb7416e225fab10c5c15a is the same patch in a different repo
  
  Fixes https://bugs.launchpad.net/unity-2d/+bug/966236
  
  [Impact]
  Severity: Can't drag and drop to Unity-2d launchers in non primary screen
- Frequency: Every time you try to do it :D
+ Frequency: Every time you try to do it
  
  [Development Fix]
  Fix the drag and drop code
  
  [Test Case]
  Copied from the unity-2d bug:
    Setup:
      Multi-monitors, launcher per screen
  
    Steps to Repro:
      1. On non-primary screen, open dash
      2. Grab an application icon and try to drag & drop it onto the launcher of
         non-primary screen
  
      Expected Result:
         Application tile created in Launcher for that application
  
      Actual Result:
        .desktop file is placed on desktop under launcher
  
  [Test Case #2]
  If you are hardcore you can actually run the unit-tests I added in https://codereview.qt-project.org/#change,24361 itself
  
  [Regression Potential]
  It is touching the Drag and Drop code, potentially any drag and drop from a Qt program might break

** Description changed:

  In Unity-2d we use input shaping to define which part of our window
  accepts user input, unfortunately Qt did not have support for that
  feature when dragging from a Qt applications resulting in impossibility
  of dragging in applications like Mumble or KMail.
  
  We fixed this issue with a patch to Qt (that was accepted upstream) but
  sadly that patch had a bug.
  
  This means we need a new patch otherwise when on multimonitor scenarios
  the dropping into the secondary launcher from the drash does still does
  not work.
  
  The new upstream patch (already accepted) can be found at https://codereview.qt-project.org/#change,24361 (it needs to replace/update kubuntu_33_shaped_drag.diff that only had a partial version of the patch)
  If it helps http://qt.gitorious.org/qt/qt/commit/c3eb2e63425c47b8e3eeb7416e225fab10c5c15a is the same patch in a different repo
  
  Fixes https://bugs.launchpad.net/unity-2d/+bug/966236
  
  [Impact]
  Severity: Can't drag and drop to Unity-2d launchers in non primary screen
  Frequency: Every time you try to do it
  
  [Development Fix]
  Fix the drag and drop code
+ https://codereview.qt-project.org/#change,24361
+ http://qt.gitorious.org/qt/qt/commit/c3eb2e63425c47b8e3eeb7416e225fab10c5c15a
+ 
  
  [Test Case]
  Copied from the unity-2d bug:
    Setup:
      Multi-monitors, launcher per screen
  
    Steps to Repro:
      1. On non-primary screen, open dash
      2. Grab an application icon and try to drag & drop it onto the launcher of
         non-primary screen
  
      Expected Result:
         Application tile created in Launcher for that application
  
      Actual Result:
        .desktop file is placed on desktop under launcher
  
  [Test Case #2]
  If you are hardcore you can actually run the unit-tests I added in https://codereview.qt-project.org/#change,24361 itself
  
  [Regression Potential]
  It is touching the Drag and Drop code, potentially any drag and drop from a Qt program might break

-- 
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to qt4-x11 in Ubuntu.
https://bugs.launchpad.net/bugs/999522

Title:
  [SRU] Fix problems in Qt dragging when all of the window target has
  been shaped out for input

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qt4-x11/+bug/999522/+subscriptions