[Bug 1022414] [NEW] konquets existsing game aborts without warning if new selected from game menu

[michael]

Public bug reported:

konquest exectutes the following on selecting game->new.
MainWindow::startNewGame()
{
    m_gameView->deleteLater();
    m_game->deleteLater();
    setupGameView();
    m_gameView->startNewGame();
}

By calling  setupGameView(); we are aborting the current game
regardlless of whether or not the new game dialog is cancled. This
should only only be done if GameView::shutdownGame() returns true. This
is a possiable regression from 4.8.3.

** Affects: kdegames (Ubuntu)
     Importance: Undecided
         Status: New

** Description changed:

  konquest exectutes the following on selecting game->new.
  MainWindow::startNewGame()
  {
-     m_gameView->deleteLater();
-     m_game->deleteLater();
-     setupGameView();
-     m_gameView->startNewGame();
+     m_gameView->deleteLater();
+     m_game->deleteLater();
+     setupGameView();
+     m_gameView->startNewGame();
  }
  
  By calling  setupGameView(); we are aborting the current game
- regardlless of whether or not the new game dialog is cancled. This a
- regression from 4.8.3 which only did this if GameView::shutdownGame()
- returned true.
+ regardlless of whether or not the new game dialog is cancled. This
+ should only only be done if GameView::shutdownGame() returns true. This
+ a possiable regression from 4.8.3.

** Description changed:

  konquest exectutes the following on selecting game->new.
  MainWindow::startNewGame()
  {
      m_gameView->deleteLater();
      m_game->deleteLater();
      setupGameView();
      m_gameView->startNewGame();
  }
  
  By calling  setupGameView(); we are aborting the current game
  regardlless of whether or not the new game dialog is cancled. This
  should only only be done if GameView::shutdownGame() returns true. This
- a possiable regression from 4.8.3.
+ is a possiable regression from 4.8.3.

-- 
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to kdegames in Ubuntu.
https://bugs.launchpad.net/bugs/1022414

Title:
  konquets existsing game aborts without warning if new selected from
  game menu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/kdegames/+bug/1022414/+subscriptions