[Bug 976071] [muon] /: Show the package name as a technical package's name, and its short description as the comment.

[Jonathan Thomas]

Git commit 112811cb23b2e2779b9d917bc86b03e10955d83f by Jonathan Thomas.
Committed on 08/04/2012 at 17:52.
Pushed by jmthomas into branch 'master'.

Show the package name as a technical package's name, and its short description as the comment.
This is necessary for displaying technical packages in the MSC, since sorting by short desc. takes 11 seconds on 50,000 packages.

With this change, I've also made all of the non-categorized app views (E.g. per-origin ones) display technical packages by default.
I'll probably also add a runtime toggle so that the "Provided by Kubuntu" entry doesn't become *totally* unnavigable if somebody doesn't care about technical packages.

As a side effect, the Muon Updater now shows the package name for the
updates in the "System Updates" category.

CCMAIL:976071 at bugs.launchpad.net
FEATURE:294172
FIXED-IN:1.4.0

M  +1    -4    installer/ApplicationWindow.cpp
M  +3    -7    libmuon/Application.cpp

http://commits.kde.org/muon/112811cb23b2e2779b9d917bc86b03e10955d83f

diff --git a/installer/ApplicationWindow.cpp b/installer/ApplicationWindow.cpp
index 0841a77..1b3c87a 100644
--- a/installer/ApplicationWindow.cpp
+++ b/installer/ApplicationWindow.cpp
@@ -399,10 +399,7 @@ void ApplicationWindow::changeView(const QModelIndex &index)
             appView->setBackend(m_backend);
             appView->setStateFilter(stateFilter);
             appView->setOriginFilter(originFilter);
-
-            if (originFilter != QLatin1String("Debian") && originFilter != QLatin1String("Ubuntu")) {
-                appView->setShouldShowTechnical(true);
-            }
+            appView->setShouldShowTechnical(true);
         }
         break;
         case CatView: {
diff --git a/libmuon/Application.cpp b/libmuon/Application.cpp
index 3d40295..f7fb6c3 100644
--- a/libmuon/Application.cpp
+++ b/libmuon/Application.cpp
@@ -84,8 +84,8 @@ QString Application::name()
     if (!m_isTechnical)
         return i18n(untranslatedName().toUtf8());
 
-    // Technical packages use the package desc, which is translated by apt
-    return m_package->shortDescription();
+    // Technical packages use the package name, which is untranslatable
+    return m_package->latin1Name();
 }
 
 QString Application::untranslatedName()
@@ -109,11 +109,7 @@ QString Application::comment()
         // Sometimes GenericName is used instead of Comment
         comment = getField("GenericName");
         if (comment.isEmpty()) {
-            if (m_isTechnical) {
-                return package()->name();
-            } else {
-                return package()->shortDescription();
-            }
+            return package()->shortDescription();
         }
     }

-- 
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to muon in Ubuntu.
https://bugs.launchpad.net/bugs/976071

Title:
  Muon Software Center needs "technical items" option

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/muon/+bug/976071/+subscriptions