[Bug 490353] extragear/sysadmin/libqapt/utils/qapt-batch

[Jonathan Thomas]

SVN commit 1188596 by jmthomas:

Don't say we were successful if there were errors. That looks a bit
silly, especially when we have error dialogs to contradict ourselves.

CCMAIL:490353 at bugs.launchpad.net


 M  +19 -1     qaptbatch.cpp  


--- trunk/extragear/sysadmin/libqapt/utils/qapt-batch/qaptbatch.cpp #1188595:1188596
@@ -320,13 +320,19 @@
             show();
             break;
         case QApt::CacheUpdateFinished:
+            setWindowTitle(i18nc("@title:window", "Refresh Complete"));
             if (m_warningStack.size() > 0) {
                 showQueuedWarnings();
             }
             if (m_errorStack.size() > 0) {
                 showQueuedErrors();
             }
-            setLabelText(i18nc("@title:window", "Package information successfully refreshed"));
+
+            if (m_errorStack.size() > 0) {
+                setLabelText(i18nc("@info:status", "Refresh completed with errors"));
+            } else {
+                setLabelText(i18nc("@label", "Package information successfully refreshed"));
+            }
             disconnect(this, SIGNAL(cancelClicked()), m_worker, SLOT(cancelDownload()));
             progressBar()->setValue(100);
             m_detailsWidget->hide();
@@ -364,15 +370,27 @@
             }
             if (m_mode == "install") {
                 setWindowTitle(i18nc("@title:window", "Installation Complete"));
+
+                if (m_errorStack.size() > 0) {
+                    setLabelText(i18nc("@label",
+                                       "Package installation finished with errors."));
+                } else {
                 setLabelText(i18ncp("@label",
                                     "Package successfully installed",
                                     "Packages successfully installed", m_packages.size()));
+                }
             } else if (m_mode == "uninstall") {
                 setWindowTitle(i18nc("@title:window", "Removal Complete"));
+
+                if (m_errorStack.size() > 0) {
+                    setLabelText(i18nc("@label",
+                                       "Package removal finished with errors."));
+                } else {
                 setLabelText(i18ncp("@label",
                                     "Package successfully uninstalled",
                                     "Packages successfully uninstalled", m_packages.size()));
             }
+            }
             progressBar()->setValue(100);
             m_done = true;
             // Really a close button, but KProgressDialog use ButtonCode Cancel

-- 
install-package incorrectly displays package installed successfully
https://bugs.launchpad.net/bugs/490353
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to qapt in ubuntu.