[Bug 69200] Re: userconfig crashes while loading group id's

[sebas]

On Sunday 28 January 2007 16:01:30 Leo Milano wrote:
> What I was proposing has not been applied. The first
> few lines of the function should looke like this:
>     #######################################################################
>      def __selectGroup(self,groupid):
> -        if groupid:
> -            self.selectedgroupid = groupid
> -            lvi = self.groupidsToListItems[groupid]
> -            self.grouplist.setSelected(lvi,True)
>
> Everything else in the function should be enclosed in the same "if
> groupid". That is, the validation for the function belongs to the
> function, not to the functon callers.
>
> The version I am seeing in websvn is rev=621399. Here is the full path:
>
> http://websvn.kde.org/trunk/playground/base/guidance/userconfig/userconfig.
>py?rev=621399&view=markup
>
> Am I looking at the wrong place ?

No, I think your patch was wrong. :>

Your patch removes that check for groupid (which isn't in there in the first 
place), so I couldn't apply it (and thought someone else had fixed it in the 
meantime).

If you can confirm that your patch has to be applied with -R, I'd be happy to 
do it.

Cheers,
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
War doesn't determine who's right, only who's left.

-- 
userconfig crashes while loading group id's
https://launchpad.net/bugs/69200