[Bug 69494] Re: Kopete 0.12.3 can't log in to ICQ anymore

[Robert Penz]

According to this SVN patch the above fix works only if you set kopete
to online but not if you choose e.g.away.

SVN commit 600976 by rjarosz:

Fix bug when going online with any other status than online i.e. away, n/a... Kopete indicates the account as online.
The status on a server is correct.

Reported by Jan Ritzerfeld, thanks.
Please test it.

CCBUG: 136566


 M  +4 -2      liboscar/client.cpp  
 M  +1 -1      oscaraccount.cpp  


--- branches/KDE/3.5/kdenetwork/kopete/protocols/oscar/liboscar/client.cpp #600975:600976
 @ -340,7 +340,6  @
                //we've finished logging in. start the services setup
                kdDebug(OSCAR_RAW_DEBUG) << k_funcinfo << "stage two done. setting up services" << endl;
                initializeStaticTasks();
-               d->ownStatusTask->go();
                ServiceSetupTask* ssTask = new ServiceSetupTask( d->connections.defaultConnection()->rootTask() );
                connect( ssTask, SIGNAL( finished() ), this, SLOT( serviceSetupFinished() ) );
                ssTask->go( true ); //fire and forget
 @ -398,9 +397,12  @
        d->active = true;
 
        if ( isIcq() )
-       {
                setStatus( d->connectAsStatus, d->connectWithMessage );
 
+       d->ownStatusTask->go();
+
+       if ( isIcq() )
+       {
                //retrieve offline messages
                Connection* c = d->connections.connectionForFamily( 0x0015 );
                if ( !c )
--- branches/KDE/3.5/kdenetwork/kopete/protocols/oscar/oscaraccount.cpp #600975:600976
 @ -560,7 +560,7  @
        /* We're not even online or connecting
         * (when getting server contacts), so don't bother
         */
-       if ( !myself()->isOnline() )
+       if ( !engine()->isActive() )
        {
                kdDebug(OSCAR_GEN_DEBUG) << k_funcinfo << "Can't add contact, we are offline!" << endl;
                return false;

-- 
Kopete 0.12.3 can't log in to ICQ anymore
https://launchpad.net/bugs/69494