<div dir="ltr"><div dir="ltr"><br></div>This should have been NACK'ed earlier.  It was sent as a PR which has been merged.<div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 19, 2024 at 1:35 PM Philip Cox <<a href="mailto:philip.cox@canonical.com">philip.cox@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">BugLink: <a href="https://bugs.launchpad.net/bugs/2060992" rel="noreferrer" target="_blank">https://bugs.launchpad.net/bugs/2060992</a><br>
<br>
SRU Justification:<br>
<br>
[Impact]<br>
The FACS field in the ACPI table is optional, but can be used communicate the hardware_signature field. If this field changes on resuming from a hibernation a clean reboot should happen rather than the resume from hibernation.<br>
<br>
On hardware reduced platforms[0] this field may exist but it is not exposed currently.<br>
<br>
[Fix]<br>
Expose this field even on hardware reduced platforms.<br>
<br>
<a href="https://lore.kernel.org/lkml/20240312134148.727454-1-dwmw2@infradead.org" rel="noreferrer" target="_blank">https://lore.kernel.org/lkml/20240312134148.727454-1-dwmw2@infradead.org</a><br>
<br>
[Test Plan]<br>
AWS test.<br>
<br>
[Where problems could occur]<br>
If on hardware reduced platforms that incorrectly support/advertise the FACS field, hibernation may break if it returns a hardware signature that changes.<br>
<br>
[Other info]<br>
SF# 00383181<br>
<br>
[0]: See Section 4.1 of the ACPI spec for info on hardware-reduced platforms.<br>
<a href="https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/04_ACPI_Hardware_Specification/ACPI_Hardware_Specification.html" rel="noreferrer" target="_blank">https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/04_ACPI_Hardware_Specification/ACPI_Hardware_Specification.html</a><br>
<br>
<br>
</blockquote></div></div></div>