<html><head></head><body><div>On Fri, 2024-04-19 at 16:09 +0200, Thibault Ferrante wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>BugLink: <a href="https://bugs.launchpad.net/bugs/2062129">https://bugs.launchpad.net/bugs/2062129</a><br></div><div><br></div><div>[Impact]<br></div><div>Division by zero can be triggered when resetting/disabling<br></div><div>the adapter<br></div><div><br></div><div>[Fix]<br></div><div>Explicitely check for 0 divider before going through this path<br></div><div><br></div><div>[Test Plan]<br></div><div>Test on according hardware:<br></div><div>1. tc qdisc add dev ${ETHERNET_INTERFACE} handle 8001: parent root mqprio num_tc 4 map 0 1 2 3 3 3 3 3 3 3 3 3 3 3 3 3 queues 1@0 1@1 1@2 1@3 hw 0<br></div><div>2. tc qdisc replace dev ${ETHERNET_INTERFACE} parent 8001:4 etf offload clockid CLOCK_TAI delta 500000<br></div><div>3. tc qdisc delete dev ${ETHERNET_INTERFACE} root<br></div><div>4. Repeate Step 1, 2 again.<br></div><div><br></div><div>[Where problems could occur]<br></div><div>Regression on IGC ethernet driver<br></div><div><br></div><div><br></div><div>Thibault Ferrante (1):<br></div><div> UBUNTU: SAUCE: igc: Fix divide error<br></div><div><br></div><div> drivers/net/ethernet/intel/igc/igc_tsn.c | 2 +-<br></div><div> 1 file changed, 1 insertion(+), 1 deletion(-)<br></div><div><br></div><div>-- <br></div><div>2.43.0<br></div><div><br></div><div><br></div></blockquote><div><br></div><div><span><pre>-- <br></pre><pre>Acked-by: Philip Cox <philip.cox@canonical.com> </pre></span></div></body></html>