<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> Hi,<o:p></o:p> This series was applied already as we tried to compile the “master-next” branch and it failed:<o:p></o:p> <o:p> </o:p> /workspace/kernel/linux/net/sched/act_sample.c:293:18: error: initialization of 'void (*)(struct tc_action *, u64, u32, u64, bool)' {aka 'void (*)(struct tc_action *, long long unsigned int, unsigned int, long long unsigned int, _Bool)'} from incompatible pointer type 'void (*)(struct tc_action *, u64, u64, u64, u64, bool)' {aka 'void (*)(struct tc_action *, long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, _Bool)'} [-Werror=incompatible-pointer-types]<o:p></o:p> 293 | .stats_update = tcf_sample_stats_update,<o:p></o:p> | ^~~~~~~~~~~~~~~~~~~~~~~<o:p></o:p> /workspace/kernel/linux/net/sched/act_sample.c:293:18: note: (near initialization for 'act_sample_ops.stats_update')<o:p></o:p> <o:p> </o:p> <pre>cc1: some warnings being treated as errors<o:p></o:p></pre> <o:p> </o:p> <o:p> </o:p> <pre>make[4]: *** [/workspace/kernel/linux/scripts/Makefile.build:272: net/sched/act_sample.o] Error 1<o:p></o:p></pre> <pre>make[4]: *** Waiting for unfinished jobs....<o:p></o:p></pre> <o:p> </o:p> <o:p> </o:p> Bartlomiej,<o:p></o:p> Do you have some sort of CI that can catch these issues?<o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> Vladimir<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: William Tu <witu@nvidia.com> Sent: Monday, April 10, 2023 11:30 AM To: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com> Cc: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>; Bodong Wang <bodong@nvidia.com>; Vladimir Sokolovsky <vlad@nvidia.com>; Paul Blakey <paulb@nvidia.com>; Dann Frazier <dann.frazier@canonical.com> Subject: Re: APPLIED: [SRU][F:linux-bluefield][PATCH v1 0/3] Support hardware stats for tc actions<o:p></o:p> </div> </div> <o:p> </o:p> Hi Bartlomiej,<o:p></o:p> <o:p> </o:p> Sorry! If it’s not too late, olease do not apply this series, we found compile error due to missing commit.<o:p></o:p> We’re working on the fix.<o:p></o:p> William<o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> From: Bartlomiej Zolnierkiewicz <<a href="mailto:bartlomiej.zolnierkiewicz@canonical.com">bartlomiej.zolnierkiewicz@canonical.com</a>> Date: Wednesday, April 5, 2023 at 4:09 AM To: William Tu <<a href="mailto:witu@nvidia.com">witu@nvidia.com</a>> Cc: Ubuntu Kernel Team <<a href="mailto:kernel-team@lists.ubuntu.com">kernel-team@lists.ubuntu.com</a>>, Bodong Wang <<a href="mailto:bodong@nvidia.com">bodong@nvidia.com</a>>, Vladimir Sokolovsky <<a href="mailto:vlad@nvidia.com">vlad@nvidia.com</a>>, Paul Blakey <<a href="mailto:paulb@nvidia.com">paulb@nvidia.com</a>>, Dann Frazier <<a href="mailto:dann.frazier@canonical.com">dann.frazier@canonical.com</a>> Subject: APPLIED: [SRU][F:linux-bluefield][PATCH v1 0/3] Support hardware stats for tc actions<o:p></o:p> </div> <div> External email: Use caution opening links or attachments Applied to focal:linux-bluefield/master-next. Thanks. -- Best regards, Bartlomiej On Tue, Apr 4, 2023 at 12:39 AM William Tu <<a href="mailto:witu@nvidia.com">witu@nvidia.com</a>> wrote: > > BugLink: <a href="https://bugs.launchpad.net/bugs/2015136">https://bugs.launchpad.net/bugs/2015136</a> > > * Explain the bug(s) > > tc hardware stats are not offloaded from some offloaded actions (pedit, sample, skbedit) > > * brief explanation of fixes > > Implement the necessary callbacks to report back stats for these actions. > > * How to test > > Configure two mlx5 rep devices and VFs. > Add tc offloaded tc rules with pedit action, and hit that rule with traffic > > Ido Schimmel (1): > sched: act_sample: Implement stats_update callback > > Petr Machata (2): > sched: act_skbedit: Implement stats_update callback > sched: act_pedit: Implement stats_update callback > > net/sched/act_pedit.c | 11 +++++++++++ > net/sched/act_sample.c | 11 +++++++++++ > net/sched/act_skbedit.c | 11 +++++++++++ > 3 files changed, 33 insertions(+) ><o:p></o:p> </div> </div> </body> </html>