<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> Hi Bartlomiej,<o:p></o:p> Thanks for your reviews of this series.<o:p></o:p> I will fix them and resubmit!<o:p></o:p> William<o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> From: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com> Date: Tuesday, March 28, 2023 at 9:18 AM To: William Tu <witu@nvidia.com> Cc: kernel-team@lists.ubuntu.com <kernel-team@lists.ubuntu.com>, Bodong Wang <bodong@nvidia.com>, Vladimir Sokolovsky <vlad@nvidia.com>, dann.frazier@canonical.com <dann.frazier@canonical.com> Subject: Re: [SRU][F:linux-bluefield][PATCH v1 0/5] Support hardware miss to tc action<o:p></o:p> </div> <div> External email: Use caution opening links or attachments On Thu, Mar 23, 2023 at 8:18 PM William Tu <witu@nvidia.com> wrote: > > Currently tc miss interface only supports resuming from a specific tc chain. > If a packet modification is done before a missable action such as CT and > there is a miss in CT after it, this may cause a miss match when resuming > re-executing the same chain in software, and wrong packet count. > This use case for example is a stateless (static) nat. > > * brief explanation of fixes > > Add support for missing to a specific action instance, and support > of per action hardware stats to update what was actually done in hardware. > > BugLink: <a href="https://bugs.launchpad.net/bugs/2012571">https://bugs.launchpad.net/bugs/2012571</a> > > Eric Dumazet (1): > net/sched: flower: fix fl_change() error recovery path > > Paul Blakey (4): > net/sched: Provide act to offload action > net/sched: cls_api: Support hardware miss to tc action > net/sched: flower: Move filter handle initialization earlier > net/sched: flower: Support hardware miss to tc action > > include/linux/skbuff.h | 6 +- > include/net/flow_offload.h | 2 + > include/net/pkt_cls.h | 30 +++-- > include/net/sch_generic.h | 2 + > net/openvswitch/flow.c | 3 +- > net/sched/cls_api.c | 217 +++++++++++++++++++++++++++++++++++-- > net/sched/cls_flower.c | 79 +++++++++----- > 7 files changed, 288 insertions(+), 51 deletions(-) Hi William, Please try using the "--dry-run" parameter for the "git send-email" command to make sure that your submission is correct (no duplicate emails and correctly threaded). This parameter makes the command do everything except actually sending the emails. You may also try sending the submission to your email address first (to double check everything) before posting to a mailing list. Please also see my replies to individual patches. Best Regards, Bartlomiej<o:p></o:p> </div> </div> </body> </html>