<div dir="ltr">Hi Tim,<div><br></div><div>My apologies, I forgot that the bug was private.  I have now changed it to public for review.</div><div><br></div><div>Thanks,</div><div>Michael</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Nov 14, 2022 at 8:26 AM Tim Gardner <<a href="mailto:tim.gardner@canonical.com">tim.gardner@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 11/10/22 6:26 PM, Michael Reed wrote:<br>
> From: Michael Reed <<a href="mailto:Michael.Reed@canonical.com" target="_blank">Michael.Reed@canonical.com</a>><br>
> <br>
> [Impact]<br>
> Ubuntu 22.04 host fails to reconnect successfully to the NVMe TCP target after link down event if the number of queues have changed post link down.<br>
> <br>
> [Fix]<br>
> Following upstream patch set helps address the issue.<br>
> <br>
> 1.<br>
> nvmet: Expose max queues to configfs<br>
> <a href="https://git.infradead.org/nvme.git/commit/2c4282742d049e2a5ab874e2b359a2421b9377c2" rel="noreferrer" target="_blank">https://git.infradead.org/nvme.git/commit/2c4282742d049e2a5ab874e2b359a2421b9377c2</a><br>
> <br>
> 2.<br>
> nvme-tcp: Handle number of queue changes<br>
> <a href="https://git.infradead.org/nvme.git/commit/516204e486a19d03962c2757ef49782e6c1cacf4" rel="noreferrer" target="_blank">https://git.infradead.org/nvme.git/commit/516204e486a19d03962c2757ef49782e6c1cacf4</a><br>
> <br>
> 3.<br>
> nvme-rdma: Handle number of queue changes<br>
> <a href="https://git.infradead.org/nvme.git/commit/e800278c1dc97518eab1970f8f58a5aad52b0f86" rel="noreferrer" target="_blank">https://git.infradead.org/nvme.git/commit/e800278c1dc97518eab1970f8f58a5aad52b0f86</a><br>
> <br>
> The patch in Point 2 above helps address the failure to reconnect in NVMe TCP scenario.<br>
> <br>
> Also, following patch addresses error code parsing issue in the reconnect sequence.<br>
> <br>
> nvme-fabrics: parse nvme connect Linux error codes<br>
> <a href="https://git.infradead.org/nvme.git/commit/ec9e96b5230148294c7abcaf3a4c592d3720b62d" rel="noreferrer" target="_blank">https://git.infradead.org/nvme.git/commit/ec9e96b5230148294c7abcaf3a4c592d3720b62d</a><br>
> <br>
> [Test Plan]<br>
> <br>
> [Where problems could occur]<br>
> <br>
> [Other Info]<br>
> <br>
> Test Kernel Source<br>
> <br>
> <a href="https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/lp_1989990_nvme_tcp" rel="noreferrer" target="_blank">https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/lp_1989990_nvme_tcp</a><br>
> <br>
> Amit Engel (1):<br>
>    nvme-fabrics: parse nvme connect Linux error codes<br>
> <br>
> Daniel Wagner (3):<br>
>    nvme-tcp: handle number of queue changes<br>
>    nvme-rdma: handle number of queue changes<br>
>    nvmet: expose max queues to configfs<br>
> <br>
>   drivers/nvme/host/fabrics.c    |  6 ++++++<br>
>   drivers/nvme/host/rdma.c       | 26 +++++++++++++++++++++-----<br>
>   drivers/nvme/host/tcp.c        | 26 +++++++++++++++++++++-----<br>
>   drivers/nvme/target/configfs.c | 29 +++++++++++++++++++++++++++++<br>
>   4 files changed, 77 insertions(+), 10 deletions(-)<br>
> <br>
<br>
We can't accept patches for a public kernel from a private bug. At <br>
least, I assume that is the reason I can't see the Launchpad bug.<br>
<br>
rtg<br>
-- <br>
-----------<br>
Tim Gardner<br>
Canonical, Inc<br>
<br>
</blockquote></div>