<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 19, 2021 at 9:43 PM <<a href="mailto:chris.chiu@canonical.com">chris.chiu@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: Gwan-gyeong Mun <<a href="mailto:gwan-gyeong.mun@intel.com" target="_blank">gwan-gyeong.mun@intel.com</a>><br>
<br>
BugLink: <a href="https://bugs.launchpad.net/bugs/1926579" rel="noreferrer" target="_blank">https://bugs.launchpad.net/bugs/1926579</a><br>
<br>
TGL PSR2 hardware tracking shows momentary flicker and screen shift if<br>
TGL Display stepping is B1 from A0.<br>
It has been fixed from TGL Display stepping C0.<br>
<br>
HSDES: 18015970021<br>
HSDES: 2209313811<br>
BSpec: 55378<br>
<br>
v2: Add checking of PSR2 manual tracking (Jose)<br>
<br>
Cc: José Roberto de Souza <<a href="mailto:jose.souza@intel.com" target="_blank">jose.souza@intel.com</a>><br>
Signed-off-by: Gwan-gyeong Mun <<a href="mailto:gwan-gyeong.mun@intel.com" target="_blank">gwan-gyeong.mun@intel.com</a>><br>
Reviewed-by: José Roberto de Souza <<a href="mailto:jose.souza@intel.com" target="_blank">jose.souza@intel.com</a>><br>
Signed-off-by: José Roberto de Souza <<a href="mailto:jose.souza@intel.com" target="_blank">jose.souza@intel.com</a>><br>
Link: <a href="https://patchwork.freedesktop.org/patch/msgid/20210422160544.2427123-1-gwan-gyeong.mun@intel.com" rel="noreferrer" target="_blank">https://patchwork.freedesktop.org/patch/msgid/20210422160544.2427123-1-gwan-gyeong.mun@intel.com</a><br>
(cherry picked from commit 8804325861be242a420d68c0175127a5947ac35a)<br>
Signed-off-by: Chris Chiu <<a href="mailto:chris.chiu@canonical.com" target="_blank">chris.chiu@canonical.com</a>><br>
---<br>
 drivers/gpu/drm/i915/display/intel_psr.c | 7 +++++++<br>
 1 file changed, 7 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c<br>
index 8ada4f829cab..056dcc2ec4ce 100644<br>
--- a/drivers/gpu/drm/i915/display/intel_psr.c<br>
+++ b/drivers/gpu/drm/i915/display/intel_psr.c<br>
@@ -804,6 +804,13 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,<br>
                }<br>
        }<br>
<br>
+       /* Wa_2209313811 */<br>
+       if (!crtc_state->enable_psr2_sel_fetch &&<br>
+           IS_TGL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B1)) {<br>
+               drm_dbg_kms(&dev_priv->drm, "PSR2 HW tracking is not supported this Display stepping\n");<br>
+               return false;<br>
+       }<br>
+<br>
        if (!crtc_state->enable_psr2_sel_fetch &&<br>
            (crtc_hdisplay > psr_max_h || crtc_vdisplay > psr_max_v)) {<br>
                drm_dbg_kms(&dev_priv->drm,<br>
-- <br>
2.25.1<br>
<br>
<br>
-- <br>
kernel-team mailing list<br>
<a href="mailto:kernel-team@lists.ubuntu.com" target="_blank">kernel-team@lists.ubuntu.com</a><br>
<a href="https://lists.ubuntu.com/mailman/listinfo/kernel-team" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/kernel-team</a></blockquote><div><br></div><div><br></div><div>Fail to compile on Hirsute and Impish due to undefined macros. Need v2 to fix </div></div></div>