<html><head></head><body><div>On Thu, 2018-06-21 at 12:06 +0530, Siva Rebbagondla wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 21, 2018 at 11:27 AM, Shrirang Bagul <span dir="ltr"><<a href="mailto:shrirang.bagul@canonical.com" target="_blank">shrirang.bagul@canonical.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">On Wed, 2018-06-20 at 19:13 +0530, Siva Rebbagondla wrote:<br> > From: Siva Rebbagondla <<a href="mailto:siva.rebbagondla@redpinesignals.com">siva.rebbagondla@<wbr>redpinesignals.com</a>><br> > <br> > <a href="https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773410" rel="noreferrer" target="_blank">https://bugs.launchpad.net/<wbr>ubuntu/+source/linux/+bug/<wbr>1773410</a><br> > <a href="https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1777850" rel="noreferrer" target="_blank">https://bugs.launchpad.net/<wbr>ubuntu/+source/linux/+bug/<wbr>1777850</a><br> > <br> > Kernel panic is observed when network manager is stopped while system<br> > is entering into hibernation. The root cause of the issue is scan work<br> > function keeps running even after cancel_hw_scan() call.<br> > Issue is resolved by calling cancel_work_sync().<br> > <br> > [ 1171.913244] BUG: unable to handle page request at 00000000001067e38<br> > [ 1171.913248] IP: cfg80211_scan_done+0xb0/0xc0 [cfg80211]<br> > [ 1171.913554] Hardware name: Dell Inc. Edge Gateway 3003/ , BIOS 01.00.06<br> > 01/22/2018<br> > [ 1171.913668] Workqueue: phy1 ieee80211_scan_work [mac80211]<br> > [ 1171.913773] RIP: 0010:cfg80211_scan_done+0xb0/<wbr>0xc0 [cfg80211]<br> > [ 1171.913780] RSP: 0018:ffffc1fe41b47dc8 EFLAGS: 00010286<br> > [ 1171.913789] RAX: 0000000000000001 RBX: ffffffffc0e60120 RCX: 0000000100080006<br> > [ 1171.913794] RDX: ffff9eeab7e3bc58 RSI: ffff9eeab0c69080 RDI: ffff9eeab7e3bc00<br> > [ 1171.913799] RBP: ffff9eeab7e3bc00 R08: 00000000b7e3b201 R09: 0000000100080006<br> > [ 1171.913805] R10: ffffc1fe41b47d20 R11: 0000000000000000 R12: ffff9eeab0c69080<br> > [ 1171.913810] R13: 0000000000000022 R14: ffff9eeab0c68760 R15: ffff9eeab7af3c00<br> > [ 1171.913817] FS: 0000000000000000(0000) GS:ffff9eeab0000000(0000)<br> > knlGS:0000000000000000<br> > [ 1171.913823] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033<br> > [ 1171.913828] CR2: 00007f76c73ac190 CR3: 000000006e20a000 CR4: 00000000001006f0<br> > [ 1171.913833] Call Trace:<br> > [ 1171.913864] ? rsi_mac80211_sta_remove+0x260/<wbr>0x260 [rsi_91x]<br> > [ 1171.913971] __ieee80211_scan_completed+<wbr>0xb1/0x390 [mac80211]<br> > [ 1171.914078] ieee80211_scan_work+0x7e/0x480 [mac80211]<br> > [ 1171.914098] process_one_work+0x142/0x3d0<br> > [ 1171.914111] worker_thread+0x229/0x440<br> > [ 1171.914122] kthread+0xf5/0x130<br> > [ 1171.914132] ? process_one_work+0x3d0/0x3d0<br> > [ 1171.914140] ? kthread_associate_blkcg+0x90/<wbr>0x90<br> > [ 1171.914152] ret_from_fork+0x35/0x40<br> > <br> > Signed-off-by: Siva Rebbagondla <<a href="mailto:siva.rebbagondla@redpinesignals.com">siva.rebbagondla@<wbr>redpinesignals.com</a>><br> Acked-By: Shrirang Bagul <<a href="mailto:shrirang.bagul@canonical.com">shrirang.bagul@canonical.com</a>><br> > ---<br> > v2: Added enhancement in case of AP mode [Shrirang]<br> Why do you need my name in the changelog of the patch?<br></blockquote><div><div style="color:rgb(7,55,99);display:inline" class="gmail_default">Hi Shrirang,</div><div style="color:rgb(7,55,99);display:inline" class="gmail_default"><br></div><div style="color:rgb(7,55,99);display:inline" class="gmail_default">Because, As you pointed v1 patch is not solved the issue and need some enhancement in patch.</div><div style="color:rgb(7,55,99);display:inline" class="gmail_default"><br></div><div style="color:rgb(7,55,99);display:inline" class="gmail_default"> </div><div style="color:rgb(7,55,99);display:inline" class="gmail_default">If this is not required, i will remove this in upcoming patches, if any. Thanks<br></div></div></div></div></div></blockquote><div>Siva,</div><div>I don't deserve so much credit, if possible please remove it and re-submit.</div><div>While you are at it, also make sure the BugLink is in proper format:</div><div><br></div><div>BugLink: <a href="https://launchpad.net/bugs/<public_bug_number>">https://launchpad.net/bugs/<public_bug_number></a></div><div><br></div><div>Thanks,</div><div>Shrirang</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"> > ---<br> > ubuntu/rsi/rsi_91x_mac80211.c | 2 ++<br> > 1 file changed, 2 insertions(+)<br> > <br> > diff --git a/ubuntu/rsi/rsi_91x_mac80211.<wbr>c b/ubuntu/rsi/rsi_91x_mac80211.<wbr>c<br> > index 36c0cfd..a797826 100644<br> > --- a/ubuntu/rsi/rsi_91x_mac80211.<wbr>c<br> > +++ b/ubuntu/rsi/rsi_91x_mac80211.<wbr>c<br> > @@ -428,6 +428,7 @@ void rsi_mac80211_hw_scan_cancel(<wbr>struct ieee80211_hw *hw,<br> > rsi_wait_event(&common-><wbr>cancel_hw_scan_event,<br> > EVENT_WAIT_FOREVER);<br> > rsi_reset_event(&common-><wbr>cancel_hw_scan_event);<br> > + cancel_work_sync(&common-><wbr>scan_work);<br> > common->scan_request = NULL;<br> > }<br> > <br> > @@ -631,6 +632,7 @@ static void rsi_mac80211_stop(struct ieee80211_hw *hw)<br> > <br> > common->iface_down = true;<br> > #ifdef CONFIG_HW_SCAN_OFFLOAD<br> > + cancel_work_sync(&common-><wbr>scan_work);<br> > if (common->scan_in_prog) <br> > common->scan_in_prog = false;<br> > #endif</blockquote></div><br></div></div> </blockquote></body></html>