<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type"> <title></title> </head> <body bgcolor="#ffffff" text="#000000"> Tim Gardner wrote: <blockquote cite="mid:4B8BD3E9.2070803@canonical.com" type="cite"> <pre wrap="">David Partington wrote: </pre> <blockquote type="cite"> <pre wrap="">Tim Gardner wrote: </pre> <blockquote type="cite"> <pre wrap="">David Partington wrote: </pre> <blockquote type="cite"> <pre wrap="">Kernel team: I have a Biostar motherboard with the it8716 superio device. When I execute the sensors hardware monitor the VID values is incorrect, In reviewing the it87.c source I fine the following code burst: </pre> </blockquote> <pre wrap=""><snip> Well, you've gotten this far. How about a proper patch? </pre> </blockquote> <pre wrap="">Tim, Thanks for your reply. Actually in the code submitted at the bottom of my email was the suggested change. However, I did submit an actual defect report with the suggested fix as well. Please see new defect #528741. Regards, David </pre> </blockquote> <pre wrap=""> The code at the bottom of <a class="moz-txt-link-freetext" href="https://lists.ubuntu.com/archives/kernel-team/2010-February/009082.html">https://lists.ubuntu.com/archives/kernel-team/2010-February/009082.html</a> is not a proper patch wrt the Linux kernel ecosystem. See Documentation/SubmittingPatches in Linus' kernel tree at git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git. The advantage of using diff and patch is the avoidance of transcription errors when applying patches. rtg </pre> </blockquote> Okay. I have never submitted a kernel patch before - so you are correct, I probably did not follow a recommended procedure. I thought that rather than complaining about something that does not work, I endeavored to show how to fix the issue. Regards, David </body> </html>