NACK: [SRU][J:linux-gcp/N:linux-gcp][PATCH v2 0/2] Fix previous gVNIC queue depth increment on Gen3+ GCE VMs

Rickey Castillo Valenzuela rickey.castillo.valenzuela at canonical.com
Fri Sep 11 01:01:45 UTC 2026


I will submit a v3 adding the fix for R:linux-gcp and fixing bug link.

On 8/24/26 15:20, Rickey Castillo wrote:
> BugLink: https://bugs.launchpad.net/bugs/2153950
>
> SRU Justification
>
> [Impact]
>
> Previously, the maximum queue depth supported for gVNIC on overcommitted Gen3+ VMs
> (such as N4) was increased from 1K to 4K in the GCP kernel using the patchset titled
> "Support larger gVNIC queue depth on Gen3+ GCE VMs". However, the upstream commit
> 5e37d8254e7f ("gve: Add header split data path") has two additional bug-fix commits.
> This patchset targets and applies those two specific fixes.
>
> [Fix]
>
> Target patches:
> d676c9a73bdc ("gve: fix header buffer corruption with header-split and HW-GRO")
> 6bf14575c655 ("gve: fix zero-length skb frag with header-split")
>
> [Test Plan]
>
> * Compile Tested
> * Boot Tested
> * The following output indicates the feature is missing:
>      $ sudo ethtool -G ens3 rx 4096
>      netlink error: Operation not supported
>    So the test plan for Canonical was to confirm that `sudo ethtool -G enp0s0 rx
>    4096` exits successfully without an error.
> * As well as this command, it should return 4096 as max no 1024:
>    ethtool -g enp0s0
>
> [Regression potential]
>
> Regressions should only be possible when using the gVNIC device for
> networking (which depends on the gve driver), and could most likely result in
> networking failures on those configurations.
>
> [Other]
>
> SF: 00433236 (for GCP variants)
> PIT: 509371317 (for GKE variants)
>
> v2:
> Fixed backport notes and CC suppressed
>
> Ankit Garg (1):
>    gve: fix header buffer corruption with header-split and HW-GRO
>
> Jordan Rhee (1):
>    gve: fix zero-length skb frag with header-split
>
>   drivers/net/ethernet/google/gve/gve_rx_dqo.c | 33 ++++++++++++++------
>   1 file changed, 23 insertions(+), 10 deletions(-)
>



More information about the kernel-team mailing list