ACK: [SRU][R][PATCH 0/1] Fix ipsec_offload rtnetlink.sh selftest on s390x (LP: 2166631)

[Edoardo Canepa]

Acked-by: Edoardo Canepa <edoardo.canepa at canonical.com>

On 9/7/26 11:58, Andrei Gherzan via kernel-team wrote:
> BugLink: https://bugs.launchpad.net/bugs/2166631
>
> SRU Justification:
>
> [Impact]
> The ipsec_offload subtest of net/rtnetlink.sh (kselftests) fails on
> big-endian (s390x). The netdevsim driver writes the IPsec key/salt values
> to its debugfs file in CPU-native byte order, while the selftest hardcodes
> the little-endian representation, so the diff mismatches on s390x:
>
>    FAIL: ipsec_offload incorrect driver data
>    FAIL: ipsec_offload
>
> [Fix]
> Test-only change: detect big-endian via lscpu and byte-swap the test's
> input key/salt so the driver's native-order output matches the expected
> block on both endiannesses. Already applied to Focal/Jammy/Noble/Questing;
> Resolute is the only series still missing it. Cherry-picked from Noble
> commit 2e2160b90ec4.
>
> [Test Plan]
> On an s390x resolute VM: sudo ./rtnetlink.sh -t kci_test_ipsec_offload -v
>    -> PASS: ipsec_offload (was FAIL: ipsec_offload incorrect driver data).
> On x86_64: same subtest still PASS (no regression).
> Verify at the ipsec_offload subtest level: the aggregate rtnetlink.sh
> still exits non-zero on s390x due to the pre-existing, unrelated
> FAIL: bridge_parent_id (not part of this bug).
>
> [Where problems could occur]
> Extremely low: only tools/testing/selftests rtnetlink.sh is touched;
> no kernel/driver code is modified.
>
> [Other Info]
> Prerequisite commit c71bc6da6198 ("netdevsim: print human readable IP
> address") is already present in Resolute, so the Focal-specific rxipaddr
> follow-up is not needed here.
>
> Alessio Faina (1):
>    UBUNTU: [SAUCE] Fix selftest/net/rtnetlink.sh for Big Endian
>
>   tools/testing/selftests/net/rtnetlink.sh | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20260909/3fcca631/attachment-0001.sig>