NACK/Cmnt: [SRU][R][PATCH v2 0/1] UBUNTU: SAUCE: Create a linux-main-modules dependency toggle

[Alessio Faina]

On Mon, Aug 31, 2026 at 04:20:22PM +0200, Alessio Faina wrote:
> [ Impact ]
> 
> When linux-main-modules has been introduced, it added a forced
> dependency on zfs; the module is not built by test servers and leave
> developers in a bad state needing to build the module manually and
> installing it. This patch is a proposal to create a toggle to remove the
> dependency for test servers.
> 
> [ Fix ]
> 
> The fix is to add a do_linux_main_modules_depends variable in
> 0-common-vars.mk that can be externally triggered.
> This will need a patch to the test servers to set the variable to false
> when building the kernel.
> 
> [ Testing ]
> 
> Testing will check that not passing the variable to the build will
> produce a kernel with the dependency enabled, while running it in a way
> like the following one
> do_linux_main_modules_depends=false dpkg-buildpackage -us -uc -b
> will produce a kernel without the linux-main-modules dependencies.
> 
> [ What could go wrong ]
> 
> Canonical would produce one kernel with a dependency to lmm (i.e. zfs)
> for production and one with no dependencies. This should be a small
> impact as the module can be separately built and installed by a
> developer in case of need.
> 
> v2: Added comments in variant files to remind that the variable is used
> 			to toggle the dependency on linux-main-modules.
> 
> Alessio Faina (1):
>   UBUNTU: SAUCE: Create a linux-main-modules dependency toggle
> 
>  debian.master/control.d/vars.generic     | 2 ++
>  debian.master/control.d/vars.generic-64k | 2 ++
>  debian/rules.d/0-common-vars.mk          | 8 ++++++++
>  debian/scripts/control-create            | 4 ++++
>  4 files changed, 16 insertions(+)
> 
> -- 
> 2.43.0
>

NACKed for the following reasons:
  - Buglink missing
  - Will add a debug message to the build log to show the toggle has
		been set to false.