ACK: [SRU][N:linux-bluefield][PATCH v1 1/2] Revert "UBUNTU: SAUCE: mlxbf_pmc: add sysfs_attr_init() during count_clock init"

Javier Carrasco javier.carrasco at canonical.com
Tue Nov 10 09:00:31 UTC 2026


On Mon Nov 9, 2026 at 10:50 PM CET, David Thompson via kernel-team wrote:
> BugLink: https://bugs.launchpad.net/bugs/2173797
>
> This reverts commit d26c880d0f57831116abf8503a052d2535c1d4c9.
>
> Signed-off-by: David Thompson <davthompson at nvidia.com>
> ---
>  drivers/platform/mellanox/mlxbf-pmc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/mellanox/mlxbf-pmc.c b/drivers/platform/mellanox/mlxbf-pmc.c
> index 2ad9e2b0493c..299eb1161910 100644
> --- a/drivers/platform/mellanox/mlxbf-pmc.c
> +++ b/drivers/platform/mellanox/mlxbf-pmc.c
> @@ -2015,7 +2015,6 @@ static int mlxbf_pmc_init_perftype_counter(struct device *dev, unsigned int blk_
>  	if (pmc->block[blk_num].type == MLXBF_PMC_TYPE_CRSPACE) {
>  		/* Program crspace counters to count clock cycles using "count_clock" sysfs */
>  		attr = &pmc->block[blk_num].attr_count_clock;
> -		sysfs_attr_init(&attr->dev_attr.attr);
>  		attr->dev_attr.attr.mode = 0644;
>  		attr->dev_attr.show = mlxbf_pmc_count_clock_show;
>  		attr->dev_attr.store = mlxbf_pmc_count_clock_store;

Acked-by: Javier Carrasco <javier.carrasco at canonical.com>



More information about the kernel-team mailing list