[SRU][R][PATCH 11/18] ASoC: SDCA: Tidy up some memory allocations

Chris Chiu chris.chiu at canonical.com
Tue Mar 17 05:21:56 UTC 2026


From: Charles Keepax <ckeepax at opensource.cirrus.com>

BugLink: https://bugs.launchpad.net/bugs/2139391

It is slightly better to deference the type being allocate for a sizeof
rather than manually using the type. Saves effort if types change in the
future. This results in no functional changes, just tidies up the style
of the code a little.

Signed-off-by: Charles Keepax <ckeepax at opensource.cirrus.com>
Link: https://patch.msgid.link/20260115114607.271990-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie at kernel.org>
(cherry picked from commit 61d2a7699ab39d448f44919ef15c16187e6f70ec linux-next)
Signed-off-by: Chris Chiu <chris.chiu at canonical.com>
---
 sound/soc/sdca/sdca_fdl.c       | 2 +-
 sound/soc/sdca/sdca_functions.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/sdca/sdca_fdl.c b/sound/soc/sdca/sdca_fdl.c
index 3180ebd07c40..8bee9f23c473 100644
--- a/sound/soc/sdca/sdca_fdl.c
+++ b/sound/soc/sdca/sdca_fdl.c
@@ -487,7 +487,7 @@ int sdca_fdl_alloc_state(struct sdca_interrupt *interrupt)
 	struct device *dev = interrupt->dev;
 	struct fdl_state *fdl_state;
 
-	fdl_state = devm_kzalloc(dev, sizeof(struct fdl_state), GFP_KERNEL);
+	fdl_state = devm_kzalloc(dev, sizeof(*fdl_state), GFP_KERNEL);
 	if (!fdl_state)
 		return -ENOMEM;
 
diff --git a/sound/soc/sdca/sdca_functions.c b/sound/soc/sdca/sdca_functions.c
index f11523c05525..4d144d0cd372 100644
--- a/sound/soc/sdca/sdca_functions.c
+++ b/sound/soc/sdca/sdca_functions.c
@@ -950,7 +950,7 @@ static int find_sdca_entity_control(struct device *dev, struct sdca_entity *enti
 	}
 
 	control->values = devm_kcalloc(dev, hweight64(control->cn_list),
-				       sizeof(int), GFP_KERNEL);
+				       sizeof(*control->values), GFP_KERNEL);
 	if (!control->values)
 		return -ENOMEM;
 
@@ -2046,7 +2046,7 @@ static int find_sdca_filesets(struct device *dev, struct sdw_slave *sdw,
 	fwnode_property_read_u32_array(function_node, "mipi-sdca-file-set-id-list",
 				       filesets_list, num_sets);
 
-	sets = devm_kcalloc(dev, num_sets, sizeof(struct sdca_fdl_set), GFP_KERNEL);
+	sets = devm_kcalloc(dev, num_sets, sizeof(*sets), GFP_KERNEL);
 	if (!sets)
 		return -ENOMEM;
 
@@ -2073,7 +2073,7 @@ static int find_sdca_filesets(struct device *dev, struct sdw_slave *sdw,
 		dev_dbg(dev, "fileset: %#x\n", filesets_list[i]);
 
 		files = devm_kcalloc(dev, num_entries / mult_fileset,
-				     sizeof(struct sdca_fdl_file), GFP_KERNEL);
+				     sizeof(*files), GFP_KERNEL);
 		if (!files)
 			return -ENOMEM;
 
-- 
2.43.0




More information about the kernel-team mailing list