[SRU][N][PATCH 0/3] FTBFS: bcmasp phylib managed-EEE backport missing prerequisites
Alice C. Munduruca
alice.munduruca at canonical.com
Tue Jul 14 14:48:38 UTC 2026
[ Impact ]
Noble kernels with CONFIG_BCMASP=m fail to build from
source due to a broken commit from noble-stable-2026-06-16
whose defect is latent in the generic/master kernel —
master does not compile the Broadcom ASP2 driver — but
becomes a fatal compile error on any arm64 kernel which
enables the config above.
compiling drivers/net/ethernet/broadcom/asp2/bcmasp_intf.o:
bcmasp_intf.c:675:37: error: 'struct phy_device' has no member named 'eee_cfg'
bcmasp_intf.c:677:27: error: 'struct phy_device' has no member named 'enable_tx_lpi'
bcmasp_intf.c:1081:23: error: 'struct phy_device' has no member named 'eee_cfg'
bcmasp_intf.c:1364:41: error: 'struct phy_device' has no member named 'eee_cfg'
bcmasp_intf.c:1416:53: error: 'struct phy_device' has no member named 'eee_cfg'
Commit e57cfd7faf78 (“net: bcm: asp2: convert to phylib
managed EEE”, upstream 21f56ad1b211) was pulled in only
as Stable-dep-of: cbfa5be2bf64 (“net: bcmasp: fix double
free of WoL irq”). The conversion makes the driver consume
phylib managed-EEE fields (phydev->eee_cfg,
phydev->enable_tx_lpi) whose infrastructure was never
backported to Noble 6.8 — the managed-EEE consumer was
dragged in without its infrastructure. The commit is
present in master tags (132.x → 136.136) but master CI
stays green because it does not build this driver.
[ Fix ]
Revert of any managed-EEE patches. These three EEE commits
sit on top of a stack of fix commits needed by this driver,
(including a CVE fix) and so manual intervention when
reverting commit #1 in the table below was needed. This
mostly consisted in context adjustment when adding back in
eee-related fields in certain bcm structs.
# Reverted commit Subject
1 e57cfd7faf78 net: bcm: asp2: convert to phylib managed EEE
2 8d2cc390d968 net: bcm: asp2: remove tx_lpi_enabled
3 d1943caf8cd3 net: bcm: asp2: fix LPI timer handling
[ Test Plan ]
Set CONFIG_BCMASP=m in kernel annotations.
Compile Kernel with the following patches applied, and
ensure no errors terminate compilation.
[ Other Info ]
Culprit commit: e57cfd7faf78 (bcmasp managed-EEE), in
Ubuntu-6.8.0-136.136.
Most of the writing above and work on the following patches
was done by the excelent Kuan-Ying Lee who made an initial
set of reverts for noble:linux-raspi. Given that some of
those reverted patches were important fixes, I've gone
ahead and made some modifications to bring them back.
Alice C. Munduruca (3):
UBUNTU: SAUCE: Revert "net: bcm: asp2: convert to phylib managed EEE"
UBUNTU: SAUCE: Revert "net: bcm: asp2: remove tx_lpi_enabled"
UBUNTU: SAUCE: Revert "net: bcm: asp2: fix LPI timer handling"
drivers/net/ethernet/broadcom/asp2/bcmasp.h | 4 ++
.../ethernet/broadcom/asp2/bcmasp_ethtool.c | 39 +++++++++++++++++++
.../net/ethernet/broadcom/asp2/bcmasp_intf.c | 22 ++++-------
3 files changed, 51 insertions(+), 14 deletions(-)
--
2.53.0
More information about the kernel-team
mailing list