ACK: [SRU][N][PATCH v3 0/1] selftests: net: move wait_local_port_listen to lib.sh

[Jian Hui Lee]

Acked-by: Jian Hui Lee <jianhui.lee at canonical.com>

On Wed, Jun 24, 2026 at 5:14 PM ChunAn Wu via kernel-team
<kernel-team at lists.ubuntu.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2142613
>
> SRU Justification:
>
> [ Impact ]
>
> The net selftest helper wait_local_port_listen() is carried in the
> standalone tools/testing/selftests/net/net_helper.sh file in Noble. Upstream
> has moved this helper into the common tools/testing/selftests/net/lib.sh file
> and updated the affected tests to source lib.sh directly.
>
> Without this backport, affected net selftests can fail with
> "wait_local_port_listen: command not found" when tests are aligned with the
> newer upstream helper layout.
>
> [ Fix ]
>
> Backport upstream commit:
> - d9d836bfa5e6 ("selftests: net: move wait_local_port_listen to lib.sh")
>
> The backport moves wait_local_port_listen() into lib.sh, updates the Noble
> tests that used net_helper.sh to source lib.sh, removes net_helper.sh from
> TEST_FILES, and deletes the obsolete net_helper.sh file.
>
> [ Test Plan ]
>
> Validated in an Ubuntu Noble LXD VM (VM24):
>
> 1. Built the required net selftest helper binaries:
>    - udpgso_bench_tx
>    - udpgso_bench_rx
>    - xdp_dummy.o
>    - nat6to4.o
> 2. Ran affected helper users:
>    - ./udpgro.sh
>    - ./udpgro_bench.sh
>    - ./udpgro_frglist.sh
>    - ./pmtu.sh pmtu_ipv4_br_vxlan4_exception
>    - ./ipv6_route_update_soft_lockup.sh
> 3. Verified the tests completed successfully and exercised
>    wait_local_port_listen() from lib.sh.
>
> [ Where problems could occur ]
>
> The change is limited to networking selftest scripts under
> tools/testing/selftests/net. It does not change kernel runtime code. Possible
> regressions would be limited to selftest execution if a script still expects
> net_helper.sh. Noble's existing net_helper.sh users are updated in this patch.
>
> [ Other Info ]
>
> The upstream commit also touched newer selftests that do not exist in Noble
> (for example, tools/testing/selftests/drivers/net/ and busy_poll_test.sh).
> Those unrelated selftest additions were not backported.
>
> [ Changes in v3 ]
>
> - Use the short Launchpad BugLink format:
>   https://bugs.launchpad.net/bugs/2142613.
>
> [ Changes in v2 ]
>
> - Update BugLink to https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/2142613.
>
> ---
>
> Hangbin Liu (1):
>   selftests: net: move wait_local_port_listen to lib.sh
>
>  tools/testing/selftests/net/Makefile          |  2 +-
>  .../net/ipv6_route_update_soft_lockup.sh      |  1 -
>  tools/testing/selftests/net/lib.sh            | 21 ++++++++++++++++
>  tools/testing/selftests/net/net_helper.sh     | 25 -------------------
>  tools/testing/selftests/net/pmtu.sh           |  1 -
>  tools/testing/selftests/net/udpgro.sh         |  2 +-
>  tools/testing/selftests/net/udpgro_bench.sh   |  2 +-
>  tools/testing/selftests/net/udpgro_frglist.sh |  2 +-
>  tools/testing/selftests/net/udpgro_fwd.sh     |  2 +-
>  9 files changed, 26 insertions(+), 32 deletions(-)
>  delete mode 100644 tools/testing/selftests/net/net_helper.sh
>
> --
> 2.34.1
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team