NACK/Cmnt: [PATCH v3] UBUNTU: SAUCE: ASoC: qcom: x1e80100: limit speaker volumes
Stefan Bader
stefan.bader at canonical.com
Wed Apr 29 09:27:27 UTC 2026
On 22/04/2026 14:07, Tobias Heider wrote:
> BugLink: https://bugs.launchpad.net/bugs/2149808
>
> Limit the digital gain and PA volumes to a combined -3 dB in the machine
> driver to reduce the risk of speaker damage until we have active speaker
> protection in place (or higher safe levels have been established).
>
> Based on commit c481016bb4f8 ("ASoC: qcom: sc8280xp: limit speaker
> volumes") which addressed the same issue on the sc8280x SoC with some
> minor changes as explained below.
>
> The Digital Volume behaves identical to sc8280x, both use the same
> lpass-wsa-macro.
> For PA x1e80100 machines use wsa884x amplifiers which expose a linear
> scale from -9 dB to 9 dB with a 1.5 dB step size giving us
> 0 dB = -9 dB + 6 * 1.5 dB.
>
Rejected for the following reasons:
- By now resolute released and submissions are limited to SRU policy
- One problem here is the missing cover-email and going with that an
indication
about the series target. (At least "[SRU R]")
- For SRU upstream changes are the preferred approach. SAUCE should only be
used if absolutely necessary (and explained why). Non-upstream
changes have
a high chance to be forgotten moving forward. Especially now that R
is out and
everyone concentrates on S/unstable.
-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 52669 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20260429/eba7a2ee/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20260429/eba7a2ee/attachment-0001.sig>
More information about the kernel-team
mailing list