NACK/Cmnt: [SRU][P/J][PATCH v3 2/2] padata: Remove comment for reorder_work

Alice C. Munduruca alice.munduruca at canonical.com
Thu Oct 9 14:10:19 UTC 2025


On 10/9/25 10:01, Manuel Diewald wrote:
> On Wed, Oct 08, 2025 at 01:06:28PM -0400, Alice C. Munduruca wrote:
>> From: Herbert Xu <herbert at gondor.apana.org.au>
>>
>> Remove comment for reorder_work which no longer exists.
>>
>> Reported-by: Stephen Rothwell <sfr at canb.auug.org.au>
>> Fixes: 71203f68c774 ("padata: Fix pd UAF once and for all")
>> Signed-off-by: Herbert Xu <herbert at gondor.apana.org.au>
>> (cherry picked from commit 82a0302e7167d0b7c6cde56613db3748f8dd806d)
>> CVE-2024-38584
> There is a typo, CVE-2024-38584 instead of CVE-2025-38584.
>
>> Signed-off-by: Alice C. Munduruca <alice.munduruca at canonical.com>
>> ---
>>   include/linux/padata.h | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/padata.h b/include/linux/padata.h
>> index b486c7359de2..765f2778e264 100644
>> --- a/include/linux/padata.h
>> +++ b/include/linux/padata.h
>> @@ -90,7 +90,6 @@ struct padata_cpumask {
>>    * @processed: Number of already processed objects.
>>    * @cpu: Next CPU to be processed.
>>    * @cpumask: The cpumasks in use for parallel and serial workers.
>> - * @reorder_work: work struct for reordering.
>>    */
>>   struct parallel_data {
>>   	struct padata_shell		*ps;
>> -- 
>> 2.51.0
>>
>>
>> -- 
>> kernel-team mailing list
>> kernel-team at lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
> Backports look good but we need to fix the CVE ID so that the changelog
> entry is not confusing. In theory the stable lead applying the patches
> could fix this but maybe it's better to re-submit.
>
Makes sense, I was sure I checked over the patch for this exact error, 
but will resubmit.

Thanks for catching this Manuel!




More information about the kernel-team mailing list