NACK/Cmnt: [SRU][J:linux-bluefield][PATCH v2 0/1] pinctrl: mlxbf3: Fix return value check for devm_platform_ioremap_resource
Jacob Martin
jacob.martin at canonical.com
Wed May 7 19:24:56 UTC 2025
On 5/5/25 1:08 PM, Asmaa Mnebhi wrote:
> From: asmaa <asmaa at nvidia.com>
>
> BugLink: https://bugs.launchpad.net/bugs/2109973
>
> SRU Justification:
>
> [Impact]
>
> Fix return value check for devm_platform_ioremap_resource() in mlxbf3_pinctrl_probe().
>
> [Fix]
>
> * Fix return value check for devm_platform_ioremap_resource() in mlxbf3_pinctrl_probe().
>
> [Test Case]
>
> * Check that pinctrl driver is loaded without errors
>
> [Regression Potential]
>
> * This fixes a typo so unlikely to cause any regression.
>
The commit author of patch 1/1 is inconsistent with upstream. Make sure
your cherry-pick, format-patch, send-email workflow is ultimately
including a line "From: Chen Ni <nichen at iscas.ac.cn>" before the commit
message body so `git am` is aware of the original author.
Additionally, since this is a v2, it is expected and useful to other
reviewers that have not seen v1 to include a note about what was changed
in the new version in your cover letter.
Thanks,
Jacob
More information about the kernel-team
mailing list