NACK: [SRU][N:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: mlxbf-pka: upstream to 24.04 noble

[Agathe Porte]

2025-06-27 22:52 CEST, Ron Li:
> BugLink: https://bugs.launchpad.net/bugs/2115440
> 
> SRU Justification:
>  
> [Impact]
>  
> Currently, the BlueField mlxbf-pka driver is upstreamed and in sync with Ubuntu 22.04, but is missing from the 24.04 noble. Need to upstream the PKA driver support for noble.
>  
> [Fix]
>  
> * Port the mlxbf-pka driver from Ubuntu 22.04 to 24.04.
> * Test to verify the major PKA functionalities are working in 24.04.
> * Create mlxbf-pka driver patch for 24.04.
>  
> [Test Case]
>  
> * Successful build of kernel for ARM64.
> * Check if the PKA devices can be probed.
> * Run the PKA verification test defined by PKAlib and verify the result.
> * Run the PKA performance test defined by PKAlib and verify the result.
> * Run the random number test with the PKA hardware and verify the result.
>  
> [Other]
> * This code is likely to change depending on feedback we received from maintainers.
> 
> Ron Li (1):
>   platform/mellanox: Add mlxbf_pka driver for BlueField Soc
> 
>  drivers/platform/mellanox/Kconfig             |    2 +
>  drivers/platform/mellanox/Makefile            |    1 +
>  drivers/platform/mellanox/mlxbf_pka/Kconfig   |   14 +
>  drivers/platform/mellanox/mlxbf_pka/Makefile  |    9 +
>  .../mellanox/mlxbf_pka/mlxbf_pka_addrs.h      |  284 +
>  .../mellanox/mlxbf_pka/mlxbf_pka_config.h     |  229 +
>  .../mellanox/mlxbf_pka/mlxbf_pka_cpu.h        |   72 +
>  .../mellanox/mlxbf_pka/mlxbf_pka_debug.h      |   66 +
>  .../mellanox/mlxbf_pka/mlxbf_pka_dev.c        | 2414 +++++++++
>  .../mellanox/mlxbf_pka/mlxbf_pka_dev.h        |  310 ++
>  .../mellanox/mlxbf_pka/mlxbf_pka_drv.c        | 1420 +++++
>  .../mellanox/mlxbf_pka/mlxbf_pka_firmware.h   | 4823 +++++++++++++++++
>  .../mellanox/mlxbf_pka/mlxbf_pka_ioctl.h      |  127 +
>  .../mellanox/mlxbf_pka/mlxbf_pka_mmio.h       |   49 +
>  .../mellanox/mlxbf_pka/mlxbf_pka_ring.h       |  276 +
>  15 files changed, 10096 insertions(+)
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/Kconfig
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/Makefile
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/mlxbf_pka_addrs.h
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/mlxbf_pka_config.h
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/mlxbf_pka_cpu.h
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/mlxbf_pka_debug.h
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/mlxbf_pka_dev.c
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/mlxbf_pka_dev.h
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/mlxbf_pka_drv.c
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/mlxbf_pka_firmware.h
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/mlxbf_pka_ioctl.h
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/mlxbf_pka_mmio.h
>  create mode 100644 drivers/platform/mellanox/mlxbf_pka/mlxbf_pka_ring.h

(re-sending a NACK to the cover letter instead of the patch)

Rejected for the following reasons:

* For some reason the `charset` of this patch is set to `y` instead of
  `utf-8`. This prevents me from trying to apply it on
  noble:linux-bluefield.

* There is also an extra utf-8 base64 attachement with the
  signature of the mailing list, that I do not see appear from other
  submissions to this list, and that seem to confuse `git am` as well.

Please send a `v2` with a correct encoding and if possible without this
extra base64 attachement.

Additional issues to be fixed:

* Please target the SRU bug to Noble

Thanks.