[SRU][N:linux-azure-nvidia][PATCH 01/10] RDMA/mana_ib: Fix error code in probe()

John Cabaj john.cabaj at canonical.com
Thu Jun 26 21:22:53 UTC 2025


From: Dan Carpenter <dan.carpenter at linaro.org>

BugLink: https://bugs.launchpad.net/bugs/2115453

Return -ENOMEM if dma_pool_create() fails.  Don't return success.

Fixes: df91c470d9e5 ("RDMA/mana_ib: create/destroy AH")
Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>
Link: https://patch.msgid.link/2bbe900e-18b3-46b5-a08c-42eb71886da6@stanley.mountain
Reviewed-by: Long Li <longli at microsoft.com>
Signed-off-by: Leon Romanovsky <leon at kernel.org>
(cherry picked from commit 607a7dcf2e981449a4b200f497f8ea97ddb5e13f)
Signed-off-by: John Cabaj <john.cabaj at canonical.com>
---
 drivers/infiniband/hw/mana/device.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/mana/device.c
index 11f6716944ce..3a4f5c373929 100644
--- a/drivers/infiniband/hw/mana/device.c
+++ b/drivers/infiniband/hw/mana/device.c
@@ -191,8 +191,10 @@ static int mana_ib_probe(struct auxiliary_device *adev,
 
 	dev->av_pool = dma_pool_create("mana_ib_av", mdev->gdma_context->dev,
 				       MANA_AV_BUFFER_SIZE, MANA_AV_BUFFER_SIZE, 0);
-	if (!dev->av_pool)
+	if (!dev->av_pool) {
+		ret = -ENOMEM;
 		goto destroy_rnic;
+	}
 
 	ret = ib_register_device(&dev->ib_dev, "mana_%d",
 				 mdev->gdma_context->dev);
-- 
2.43.0




More information about the kernel-team mailing list