ACK: [SRU][J:gcp/gke, N:gcp/gke/gkeop][PATCH 0/5] Revert: "IDPF: TX timeout and crash"

Tim Whisonant tim.whisonant at canonical.com
Thu Jan 30 22:25:46 UTC 2025


On Thu, Jan 30, 2025 at 01:07:41PM -0800, Ian Whitfield wrote:
> BugLink: https://bugs.launchpad.net/bugs/2093622
> 
> [Impact]
> 
> This patchset previously requested by Google has been found to cause
> crashes without a dependency commit:
> e4891e4687c8 ("idpf: split &idpf_queue into 4 strictly-typed queue structures")
> This requires a rework of the patchset, so we need to pull it from the
> current cycle until further notice.
> 
> [Fix]
> 
> The patchset is reverted for all affected kernels. Another email was
> sent for the Oracular version of the patchset.
> 
> Kernel owners applying this patchset should replace the commit message
> with their specific commit hashes or otherwise re-do the reverts to get
> correct hashes, keeping the ACK lines from this thread.
> 
> [Where problems could occur]
> 
> Reverting this fix reintroduces the problems originally intended to be
> solved by the patchset, but prevents new major crashes and should
> generally be a net benefit to stability of the kernel. These kernels
> will go through normal rounds of testing for the cycle.
> 
> [Other info]
> 
> SF #00404007
> 
> Ian Whitfield (5):
>   Revert "idpf: trigger SW interrupt when exiting wb_on_itr mode"
>   Revert "idpf: add support for SW triggered interrupts"
>   Revert "idpf: fix idpf_vc_core_init error path"
>   Revert "idpf: avoid vport access in idpf_get_link_ksettings"
>   Revert "idpf: enable WB_ON_ITR"
> 
>  drivers/net/ethernet/intel/idpf/idpf.h        |  4 +--
>  drivers/net/ethernet/intel/idpf/idpf_dev.c    |  5 ---
>  .../net/ethernet/intel/idpf/idpf_ethtool.c    | 11 ++++--
>  drivers/net/ethernet/intel/idpf/idpf_lib.c    |  1 -
>  .../ethernet/intel/idpf/idpf_singleq_txrx.c   |  6 +---
>  drivers/net/ethernet/intel/idpf/idpf_txrx.c   | 36 ++++++-------------
>  drivers/net/ethernet/intel/idpf/idpf_txrx.h   | 31 ----------------
>  drivers/net/ethernet/intel/idpf/idpf_vf_dev.c |  5 ---
>  .../net/ethernet/intel/idpf/idpf_virtchnl.c   |  3 +-
>  9 files changed, 24 insertions(+), 78 deletions(-)
> 
> -- 
> 2.43.0
> 

Acked-by: Tim Whisonant <tim.whisonant at canonical.com>



More information about the kernel-team mailing list