ACK: [SRU][O][PATCH 0/4] Revert: "IDPF: TX timeout and crash"

Kevin Becker kevin.becker at canonical.com
Thu Jan 30 21:35:34 UTC 2025


On Thu, Jan 30, 2025 at 4:02 PM Ian Whitfield
<ian.whitfield at canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2093622
>
> [Impact]
>
> This patchset previously requested by Google has been found to cause
> crashes without a dependency commit:
> e4891e4687c8 ("idpf: split &idpf_queue into 4 strictly-typed queue structures")
> This requires a rework of the patchset, so we need to pull it from the
> current cycle until further notice.
>
> [Fix]
>
> The patchset is reverted for all affected kernels. Another email was
> sent for the Jammy/Noble version of the patchset.
>
> [Where problems could occur]
>
> Reverting this fix reintroduces the problems originally intended to be
> solved by the patchset, but prevents new major crashes and should
> generally be a net benefit to stability of the kernel. These kernels
> will go through normal rounds of testing for the cycle.
>
> [Other info]
>
> SF #00404007
>
> Ian Whitfield (4):
>   Revert "idpf: trigger SW interrupt when exiting wb_on_itr mode"
>   Revert "idpf: add support for SW triggered interrupts"
>   Revert "idpf: Don't hard code napi_struct size"
>   Revert "idpf: enable WB_ON_ITR"
>
>  drivers/net/ethernet/intel/idpf/idpf_dev.c    |  5 ---
>  .../ethernet/intel/idpf/idpf_singleq_txrx.c   |  6 +---
>  drivers/net/ethernet/intel/idpf/idpf_txrx.c   | 36 ++++++-------------
>  drivers/net/ethernet/intel/idpf/idpf_txrx.h   | 36 ++-----------------
>  drivers/net/ethernet/intel/idpf/idpf_vf_dev.c |  5 ---
>  5 files changed, 14 insertions(+), 74 deletions(-)
>
> --

Acked-by: Kevin Becker <kevin.becker at canonical.com>



More information about the kernel-team mailing list