ACK: [SRU][noble:linux][PATCH 0/1] Upstream commit 65357e2c164a: "RDMA/mana_ib: set node_guid" applied incorrectly

Koichiro Den koichiro.den at canonical.com
Thu Jan 30 01:55:24 UTC 2025


On Wed, Jan 29, 2025 at 02:18:12PM GMT, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2096885
> 
> SRU Justification
> 
> [Impact]
> 
> * Upstream stable commit 65357e2c164a: "RDMA/mana_ib: set node_guid" applied incorrectly to noble:linux tree
> * Commit depends on a previous commit, 8859f009ace2: "RDMA/mana_ib: Configure mac address in RNIC"
> * 8859f009ace2 also depends on previous commits regarding RNIC adapter, which are not part of the noble:linux tree to this point
> * It follows that 65357e2c164a: "RDMA/mana_ib: set node_guid" doesn't appear to be necessary and can be reverted
> 
> [Fix]
> 
> * Clean revert of 65357e2c164a: "RDMA/mana_ib: set node_guid"
> 
> [Test Plan]
> 
> * Compile tested
> 
> [Regression potential]
> 
> * Minimal regression risk as this simply fixes an incorrect patch
> * It's possible that other patches already applied to the stable tree are dependent on this patch being included. However it was done incorrectly, and likely fixes a further regression caused by the inclusion of this commit in the first place.
> 
> John Cabaj (1):
>   Revert "RDMA/mana_ib: set node_guid"
> 
>  drivers/infiniband/hw/mana/device.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Acked-by: Koichiro Den <koichiro.den at canonical.com>



More information about the kernel-team mailing list