ACK: [SRU][F][PATCH 0/1] net: stmmac: kernel continually prints wol unbalance irq warning

Tim Whisonant tim.whisonant at canonical.com
Tue Jan 28 02:09:13 UTC 2025


On Tue, Jan 21, 2025 at 10:35:53AM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2095376
> 
> [Impact]
> 
> We are working on a IoT project, when we run the uc20 on the hardware,
> a lot of warning calltrace will be printed out on the console.
> 
> 
> [Fix]
> Backport one patch from upstream.
> 
> [Test]
> Boot the patched kernel on the machine, check dmesg, there is no
> that calltrace anymore. And manually test it with 
> "ethtool -s eth0 wol d", it will not introduce calltrace any longer.
> 
> 
> [Where problems could occur]
> The change only impacts the ethertool wol function on ethernet stmmac,
> if it could introduce any regression, it will be on wol function of
> stmmac driver, but the risk of regression is very low, and we tested
> the wol with "ethtool -s eth0 wol g" and "ethtool -s eth0 wol d", the
> test result is positive.
> 
> 
> Qiang Ma (1):
>   net: stmmac: ethtool: Fixed calltrace caused by unbalanced
>     disable_irq_wake calls
> 
>  drivers/net/ethernet/stmicro/stmmac/stmmac.h         |  1 +
>  drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 10 ++++++++--
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c    |  1 +
>  3 files changed, 10 insertions(+), 2 deletions(-)
> 
> -- 
> 2.34.1
> 

Acked-by: Tim Whisonant <tim.whisonant at canonical.com>



More information about the kernel-team mailing list