NACK: [kernel-snaps-uc22][PATCH v2 0/1] add build-time check for nvidia firmware

Juerg Haefliger juerg.haefliger at canonical.com
Tue Jan 21 16:25:13 UTC 2025


ML cleanup. v3 is applied.

...Juerg


> [Changes from v1 to v2]
> - Changed version check to explicitly compare driver versions.
> 
> [Impact]
> This adds a test preventing pc-kernel builds from succeeding
> if nvidia firmware isn't present in the snap at the end of
> the build stage. This is caused by a version mismatch between the nvidia
> firmware and kernel module packages. This patch checks for these
> versions and causes the build to fail if they don't match.
> 
> [Fix]
> The snap build fails if the verison of nv.o does not match the version
> number of a firmware file picked from $SNAPCRAFT_STAGE/firmware/nvidia.
> This does not seem to be a problem on arm64, as the nvidia firmware
> directory only contains xusb firmware on this architecture.
> 
> [Regression Potential]
> Regression potential is low, as this should only affect
> build-time behavior.
> 
> Aaron Jauregui (1):
>   snapcraft.yaml: Prevent nvidia version mismatch
> 
>  snapcraft.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250121/a61dbace/attachment-0001.sig>


More information about the kernel-team mailing list