NACK/Cmnt: [PATCH 0/1][SRU][Noble] Fix spurious wakeup on HP ProOne 440

[Stefan Bader]

On 21.10.24 15:23, Chris Chiu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2085065
> 
> [Impact]
> The HP ProOne 440 AIO PC with particular LG touch panel connected via high-speed USB root hub will randomly fail to enter suspend.
> 
> [Fix]
> Fixed by a quirk for the particular HP model with LG touch panel in https://lore.kernel.org/platform-driver-x86/20240906053047.459036-1-kai.heng.feng@canonical.com/T/#m1b1f48fea9626a4fb5f199ef2304d2f61ed43f52
> 
> [Test Case]
> 1. Power on the HP AIO PC
> 2. run checkbox-cli run com.canonical.certification::suspend-cycles-stress-test
> 3. observe the suspend fail with the kernel message (PM: Some devices failed to suspend, or early wake event detected)
> 
> [Where problems could occur]
> Only affect the particular HP AIO PC. The risk is restricted.
> 
> Kai-Heng Feng (1):
>    UBUNTU: SAUCE: platform/x86/hp: Avoid spurious wakeup on HP ProOne 440
> 
>   drivers/platform/x86/hp/hp-wmi.c | 59 +++++++++++++++++++++++++++++++-
>   1 file changed, 58 insertions(+), 1 deletion(-)
> 
Rejected for the following reasons:
- this change is not upstream which it should be to avoid future 
maintenance burden
- there is no reasoning to explain why this has to be handled this way
- vaguely recalling the possibility that this was still under discussion

Since it was submitted after Noble released it will not carry forward 
into later releases. So either those break or got fixed in a different 
way. Then it might be reasonable to accept a SAUCE patch if the upstream 
backport is too invasive.
Please re-submit either with the upstream change or by explicitly 
explaining why this is not upstream. But also be aware that if we fix it 
only in Noble it will reappear with every HWE kernel update.

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 52669 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250113/22f25579/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250113/22f25579/attachment-0001.sig>