ACK/Cmnt: [SRU][N][PATCH 0/6] Unable to boot as a guest on VMware ESX

[Jacob Martin]

On Tue, Dec 17, 2024 at 03:31:04PM +0100, Thibault Ferrante wrote:
> Buglink: https://bugs.launchpad.net/bugs/2091941
> 
> [ Impact ]
> 
>  * Unable to boot as a guest in VMware on ESXi
> 
> [ Fix ]
>  * Pull all upstream commits listed here : https://lore.kernel.org/lkml/20240715151025.GAZpU74ZeeCqqMZpWw@fat_crate.local/#r
> 
> b2c13c23ea9c x86/vmware: Use VMware hypercall API
> 90328eaaff34 drm/vmwgfx: Use VMware hypercall API
> f0db90b4127c input/vmmouse: Use VMware hypercall API
> 54651bb4dcfe ptp/vmware: Use VMware hypercall API
> 34bf25e820ae x86/vmware: Introduce VMware hypercall API
> 86cb65448d07 x86/vmware: Correct macro names
> 
> [ Test Plan ]
> 
>  * Verify it boot on VMware ESX.
> 
> [ Where problems could occur ]
> 
>  * Regression on VMware support
> 
> [ Other Info ]
> 
>  * linux-intel already have those patches and was tested successfully.
> 
> 
> Alexey Makhalov (6):
>   ptp/vmware: Use VMware hypercall API
>   input/vmmouse: Use VMware hypercall API
>   drm/vmwgfx: Use VMware hypercall API
>   x86/vmware: Use VMware hypercall API
>   x86/vmware: Correct macro names
>   x86/vmware: Remove legacy VMWARE_HYPERCALL* macros
> 
>  arch/x86/include/asm/vmware.h             |  26 ---
>  arch/x86/kernel/cpu/vmware.c              | 103 ++++--------
>  drivers/gpu/drm/vmwgfx/vmwgfx_msg.c       | 173 +++++++------------
>  drivers/gpu/drm/vmwgfx/vmwgfx_msg_arm64.h | 196 +++++++++++++++-------
>  drivers/gpu/drm/vmwgfx/vmwgfx_msg_x86.h   | 185 --------------------
>  drivers/input/mouse/vmmouse.c             |  76 +++------
>  drivers/ptp/ptp_vmw.c                     |  12 +-
>  7 files changed, 250 insertions(+), 521 deletions(-)
> 
> -- 
> 2.43.0
> 

To summarize what you explained to me --

The patch adding VMware hypercall TDX support (LP#2077729) adds TDX support
only to the newer VMware hypercall API, so drivers that weren't using this API
were not TDX-aware and ran into issues when booting a VM while using TDX. The
patches in this submission resolve this by migrating the drivers to use the new
VMware hypercall API.

Looks good!

Acked-by: Jacob Martin <jacob.martin at canonical.com>