NACK: [SRU][F/J/N/O][PATCH] Source files for vmlinux not collected (LP: #2089817)

[Juerg Haefliger]

This is not sufficient for collecting vmlinux source files on all
arches and across all series.

...Juerg


On Thu, 28 Nov 2024 08:14:10 +0100
Juerg Haefliger <juerg.haefliger at canonical.com> wrote:

> https://bugs.launchpad.net/bugs/2089817
> 
> [Impact]
> 
> There's a bug in how we collect source files after the build: vmlinux is ignored, i.e. its source files are not collected :-(
> 
> The following line in the build rules is missing parenheses:
> find $(builddir)/build-$* -name vmlinux -o -name \*.ko -exec dwarfdump -i {} \;
> 
> Should be
> find $(builddir)/build-$* \( -name vmlinux -o -name \*.ko \) -exec dwarfdump -i {} \;
> 
> [Test Plan]
> 
> Inspect content of 'sources' file in linux-buildinfo package.
> 
> [Where Problems Could Occur]
> 
> Build failures.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250108/fce41a53/attachment.sig>