NACK: [SRU][N:gcp][PATCH 0/1] Backport "netkit: Add option for scrubbing skb meta data" to 6.8
Tim Whisonant
tim.whisonant at canonical.com
Mon Jan 6 18:50:48 UTC 2025
On Wed, Dec 11, 2024 at 06:12:02PM -0800, Tim Whisonant wrote:
> BugLink: https://bugs.launchpad.net/bugs/2091184
>
> SRU Justification:
>
> [Impact]
>
> * GCP states that they would like to leverage NetKit for better
> networking performance, and that recent fixes that have landed in
> mainline are necessary to avoid bugs when using Cilium.
>
> [Fix]
>
> * 83134ef46093 netkit: Add option for scrubbing skb meta data
> This was a clean cherry-pick onto 6.8.
>
> [Test Plan]
>
> * Boot-tested the changes in GCP environment on amd64 hardware.
>
> [Where problems could occur]
>
> * When running Cilium with NetKit in per-endpoint-routes mode, network
> policy misclassifies traffic. This mode is used in the case of
> GKE/EKS/AKS.
>
> [Other Info]
>
> * Changes are limited to the NetKit driver. Risk is considered low as
> the changes are limited and apply cleanly from upstream.
>
> Daniel Borkmann (1):
> netkit: Add option for scrubbing skb meta data
>
> drivers/net/netkit.c | 68 +++++++++++++++++++++++++++++-------
> include/uapi/linux/if_link.h | 15 ++++++++
> 2 files changed, 70 insertions(+), 13 deletions(-)
>
> --
> 2.43.0
>
More information about the kernel-team
mailing list