ACK: [SRU][unstable/plucky/oracular/noble:linux][PATCH 0/1] When /dev/vmbus/hv_kvp is not present, disable hv-kvp-daemon

[Magali Lemes]

On 13/12/2024 19:39, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2091744
> 
> SRU Justification
> 
> [Impact]
> 
> Re-opening for Noble, Oracular, and current development cycle (Plucky) as this appears to have accidentally been dropped.
> 
> * Previous LP bug: https://bugs.launchpad.net/bugs/2024900
> 
> * Commit from Jammy release: https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/jammy/commit/debian/linux-cloud-tools-common.hv-kvp-daemon.service?h=master-next&id=7da99ea3a1a745f6fd0c8632ef89573437888af6
> 
> * Previous mailing list discussion: https://lists.ubuntu.com/archives/kernel-team/2023-June/140646.html
> 
> Following description copied from original LP bug:
> 
> If the daemon is started and the vmbus is not present it will just exit with an error: https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/mantic/tree/tools/hv/hv_kvp_daemon.c#n1424
> 
> Thus, it would make sense to add "ConditionPathExists=/dev/vmbus/hv_kvp" in linux-cloud-tools-common.hv-kvp-daemon.service to prevent systemd from starting the daemon if the device is not there.
> 
> [Test Plan]
> 
> Start an Azure cloud instance and check for /dev/vmbus/hv_kvp and that hv-kvp-daemon is running.
> Start a non-Azure cloud instance and check that hv-kvp-daemon is not running.
> 
> [Regression potential]
> 
> Its possible that kv-hvp-daemon is not started when it should be.
> 
> Gauthier Jolly (1):
>    UBUNTU: [Packaging] disable hv-kvp-daemon if needed
> 
>   debian/linux-cloud-tools-common.hv-kvp-daemon.service | 1 +
>   1 file changed, 1 insertion(+)
> 

Acked-by: Magali Lemes <magali.lemes at canonical.com>