NACK/Cmnt: [SRU][canonical-kernel-snap/main] nvidia-hooks: fix nvidia-ko

[Stefan Bader]

On 18.02.25 06:27, Aaron Jauregui wrote:
> [Impact]
> hook scripts currently refer to the nouveau component as 'nouveau',
> which is no longer correct and will break new installs. This patch fixes
> this issue, along with correcting script permissions and quoting
> variables in scripts that I missed in the last patch.
> 
> [Fix]
> Incorrect references of nouveau component to nouveau-ko
> 
> [Test case]
> Built, installed into uc24 vm and confirmed fix by installing/removing
> components.
> 
> [Where problems could occur]
> Further regressions are unlikely as this is a simple change.
> 
> Aaron Jauregui (1):
>    nvidia-hooks: clean up scripts
> 
>   hooks/module/install.module                        |  2 +-
>   hooks/module/post-refresh.module                   |  2 +-
>   hooks/module/remove.module                         |  2 +-
>   hooks/nvidia-ko/install.nvidia-ko                  | 10 +++++-----
>   hooks/nvidia-ko/post-refresh.nvidia-ko             |  0
>   hooks/nvidia-ko/remove.nvidia-ko                   |  0
>   hooks/nvidia-user/install.nvidia-user              |  4 ++--
>   hooks/nvidia-user/kernel-gpu-2404-provider-mangler |  2 +-
>   hooks/nvidia-user/remove.nvidia-user               |  0
>   hooks/pc-kernel/install.pc-kernel                  |  4 ++--
>   hooks/pc-kernel/post-refresh.pc-kernel             |  4 ++--
>   11 files changed, 15 insertions(+), 15 deletions(-)
>   mode change 100644 => 100755 hooks/module/install.module
>   mode change 100644 => 100755 hooks/module/post-refresh.module
>   mode change 100644 => 100755 hooks/module/remove.module
>   mode change 100644 => 100755 hooks/nvidia-ko/install.nvidia-ko
>   mode change 100644 => 100755 hooks/nvidia-ko/post-refresh.nvidia-ko
>   mode change 100644 => 100755 hooks/nvidia-ko/remove.nvidia-ko
>   mode change 100644 => 100755 hooks/nvidia-user/install.nvidia-user
>   mode change 100644 => 100755 hooks/nvidia-user/kernel-gpu-2404-provider-mangler
>   mode change 100644 => 100755 hooks/nvidia-user/remove.nvidia-user
>   mode change 100644 => 100755 hooks/pc-kernel/install.pc-kernel
>   mode change 100644 => 100755 hooks/pc-kernel/post-refresh.pc-kernel
> 
Rejected for the following reasons:
- Patch does not apply. Please re-submit once you refreshed the repo

Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED
checking file hooks/module/post-refresh.module
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED
checking file hooks/module/remove.module
Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED
checking file hooks/nvidia-ko/install.nvidia-ko
Hunk #1 FAILED at 5.
Hunk #2 FAILED at 22.
2 out of 2 hunks FAILED
checking file hooks/nvidia-ko/post-refresh.nvidia-ko
checking file hooks/nvidia-ko/remove.nvidia-ko
checking file hooks/nvidia-user/install.nvidia-user
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED
checking file hooks/nvidia-user/kernel-gpu-2404-provider-mangler
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED
checking file hooks/nvidia-user/remove.nvidia-user
checking file hooks/pc-kernel/install.pc-kernel
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED
checking file hooks/pc-kernel/post-refresh.pc-kernel
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED

-Stefan

-- 
- Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 47863 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250218/ac4ac8e3/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250218/ac4ac8e3/attachment-0001.sig>