NACK[P]/ACK[N/Q]/Cmnt: [SRU][N/P/Q][PATCH 0/1] UBUNTU: SAUCE: selftests: net: fix "buffer overflow detected" for tap.c

Tim Whisonant tim.whisonant at canonical.com
Sat Dec 6 00:30:03 UTC 2025


On Thu, Dec 04, 2025 at 11:42:16PM -0500, Alice C. Munduruca wrote:
> BugLink: https://bugs.launchpad.net/bugs/2067642
> 
> [ Impact ]
> 
> Currently, the default enablement of `-D_FORTIFY_SOURCE=3` in gcc causes
> the kselftest net:tap test to fail due to an error in userspace. As this is not
> an issue with the kernel, the test itself is changed to no longer use a checked
> function (in this case using `memcpy`) to return to the previous behavior.
> 
> [ Fix ]
> 
> questing: replace the call to strcpy() with memcpy(), which is not checked.
> plucky: cleanly applied questing patch.
> noble: cleanly applied questing patch.
> jammy: Unaffected as the jammy toolchain doesn't enable this option.
> 
> [ Test Plan ]
> 
> Run the test before and after the patch and notice the difference.
> 
> [ Regression Potential ]
> 
> N/A, Kernel is not modified by this patch.
> 
> Alice C. Munduruca (1):
>   UBUNTU: SAUCE: selftests: net: fix "buffer overflow detected" for
>     tap.c
> 
>  tools/testing/selftests/net/tap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> -- 
> 2.51.0
> 
> 

This patch is..

NACK for Plucky, because we've been instructed to NACK all but
high/critical issues for Plucky.

ACK for Noble and Questing.

Acked-by: Tim Whisonant <tim.whisonant at canonical.com>



More information about the kernel-team mailing list